Revert fix-scroll-to-note
What does this MR do and why?
This reverts merge request !123957 (merged)
Alternative options in #416567 (comment 1450570799) but require further investigation.
How to set up and validate locally
- Go to issue/MR with more than a screenful of comments, deeplink to one of the comments
- Add a new comment
- Scroll position should not change
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @psimyn
To speed up your revert merge request, please consider using the revert merge request template. Adding the appropriate labels for resolving master:broken before the merge request is created will skip several CI/CD jobs.
For this merge request, if this is for resolving master:broken you can add the appropriate labels present in the merge request template, and trigger a new pipeline. It will be faster
.changed milestone to %16.2
3 Warnings In a revert merge request? Use the revert merge request template to add labels that skip changelog checks. Reverting something in the current milestone? A changelog isn't required. Skip changelog checks by adding
~"regression:*"
label, then re-run the danger job (there is a link at the bottom of this comment).The merge request title must contain at least 3 words. For more information, take a look at our Commit message guidelines. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Laura Meckley (
@lmeckley
) (UTC-6, 16 hours behind@psimyn
)Andrew Fontaine (
@afontaine
) (UTC-4, 14 hours behind@psimyn
)UX Matthew Nearents (
@mnearents
) (UTC-7, 17 hours behind@psimyn
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermentioned in issue #416567 (closed)
added pipeline:expedite label
Setting pipeline:expedite without master:broken, master:foss-broken or quarantine is forbidden!
removed pipeline:expedite label
@kushalpandya
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for 7cec1ed9 succeeds
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b047402d and 89ccf48b
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.14 MB 4.14 MB - -0.0 % mainChunk 3 MB 3 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 89ccf48bexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 6 | 9 | ❗ | | Plan | 4 | 0 | 0 | 4 | 4 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 4 | 4 | ❗ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 14 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 89ccf48bexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 1 | 9 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Usermentioned in commit e2610a71
added workflowstaging-canary label and removed workflowpost-deploy-db-production label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label