Migrate comment type dropdown to listbox
What does this MR do and why?
Migrate comment type dropdown to listbox
Replace gl-dropdown usage with gl-collapsible-listbox on app/assets/javascripts/notes/components/comment_type_dropdown.vue
Changelog: changed
Screenshots or screen recordings
| Before | After |
|---|---|
 |
 |
We lost the gap since there seems to be no gl-margin counterpart for 1/2 of the base spacing. However, I think this should be okay as it still matches up with the other split dropdown on the same page.
We also lost the divider to simplify the layout and screen reader (otherwise, we'll have to add a specific sr text for each group). Which I also think should be fine since the selected option's border still provides that pseudo divider.
LMKWYT!
How to set up and validate locally
- Open any page where you can leave a comment (issues, merge requests, etc..)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #413463 (closed)