Fix: group id missing in new resource dropdown
What does this MR do and why?
Fix #416456 (closed), the current version of the code computes the same local storage key to all groups, while clicking the create new issue in [project]
will be redirect to any project we last selected.
Amend the code with a group path injection, when no group id were passed in to the component, we should use the group path.
/cc @prajnamas @qk44077907 @orozot @fenyuluoshang
Fix: group id missing in new resource dropdown
- Convert groupId to
inject
. - Update Specs against it.
Changelog: fixed
Screencast
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added Community contribution label
added JiHu contribution label
Hey @JeremyWuuuuu!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added workflowin dev label
assigned to @JeremyWuuuuu
added linked-issue label
added 1 commit
- a3de9b67 - Fix: group id missing in new resource dropdown
7 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.01c3f4e2: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. d01cb16e: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. c7cfd527: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. Please add a merge request subtype to this merge request. This Merge Request needs to be labelled with frontend, backend. Please request a reviewer or maintainer to add them. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Ross Byrne (
@robyrne
) (UTC+1)Vitali Tatarintev (
@ck3g
) (UTC+2)frontend Artur Fedorov (
@arfedoro
) (UTC+2)Miguel Rincon (
@mrincon
) (UTC+2)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost UserLGTM. @JeremyWuuuuu
Edited by fenyuadded 499 commits
-
a3de9b67...ce1137d4 - 498 commits from branch
gitlab-org:master
- 1ec01bcf - Fix: group id missing in new resource dropdown
-
a3de9b67...ce1137d4 - 498 commits from branch
added workflowready for review label and removed workflowin dev label
requested review from @pgascouvaillancourt
@pgascouvaillancourt
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
This message was generated automatically. You're welcome to improve it.
mentioned in issue gitlab-org/quality/triage-reports#13066 (closed)
added devopsmanage groupfoundations sectiondev typebug labels
- Resolved by Paul Gascou-Vaillancourt