Hook up update schedule mutation
What does this MR do and why?
Part of the refactor of pipeline schedules to Vue/GraphQL. Hooks up the update schedule mutation and adds ability to update and destroy variables.
Screenshots or screen recordings
How to set up and validate locally
- Enable the feature flag
Feature.enable(:pipeline_schedules_vue)
- Visit
Project > Build > Pipeline schedules
- Try creating a pipeline schedule with different values and test out creation
- Then edit the pipeline schedule and ensure the values are updated correctly (try removing variables etc.)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #385101 (closed)
Merge request reports
Activity
changed milestone to %16.2
assigned to @pburdette
- A deleted user
added backend label
3 Warnings This merge request is quite big (594 lines changed), please consider splitting it into multiple merge requests. 1842262d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. fbbbabad: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/graphql/reference/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Multiversion compatibility
This merge request updates GraphQL backend and frontend code.
To prevent an incident, ensure the updated frontend code is backwards compatible.
For more information, see the multiversion compatibility documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Ian Anderson (
@imand3r
) (UTC-7, 3 hours behind@pburdette
)Mehmet Emin Inac (
@minac
) (UTC+2, 6 hours ahead of@pburdette
)frontend Ankit Panchal (
@ankit.panchal
) (UTC+5.5, 9.5 hours ahead of@pburdette
)Miguel Rincon (
@mrincon
) (UTC+2, 6 hours ahead of@pburdette
)~"Verify" Reviewer review is optional for ~"Verify" Drew Cimino (
@drew
) (UTC+0, 4 hours ahead of@pburdette
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User-
removed missed:15.9 label
removed missed:15.10 label
removed missed-deliverable label
removed workflowin dev label
added feature flagexists label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 8f3570dd and 19efac1b
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.18 MB 4.18 MB - 0.0 % mainChunk 3.09 MB 3.09 MB - 0.0 % Significant Growth: 2Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.pipeline_schedules.edit 358.4 KB 376.8 KB +18.4 KB 5.1 % pages.projects.pipeline_schedules.new 358.39 KB 376.79 KB +18.4 KB 5.1 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for 8f3570dd. So we have used data from: 29ee6216.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 19efac1bexpand test summary
+------------------------------------------------------------+ | suites summary | +-------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------+--------+--------+---------+-------+-------+--------+ +-------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 0 | 0 | 0 | ➖ | +-------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 19efac1bexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 1 | 1 | 9 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 30 | 0 | 3 | 1 | 33 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded 262 commits
-
1134df6e...3e908402 - 260 commits from branch
master
- 6cef3bbd - Add update schedule ability
- ee71db20 - Add query fetch error alert
-
1134df6e...3e908402 - 260 commits from branch
- A deleted user
added documentation label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed