Skip to content
Snippets Groups Projects

Validation to prevent default project, group visibility being restricted

Merged Roy Liu requested to merge 415524-adjust-admin-group-visibility-settings-on-saas into master

What does this MR do and why?

Related to #415524 (closed), on SaaS, user registration go through the Create or import your first project page, when either one of the default_group_visibility and default_project_visibility is restricted, user sees the following errors:

Can not create group Can not create project
group_error project_error

Screenshots or screen recordings

  • Example setting that triggers the validation error

Screenshot_2023-07-05_at_3.05.31_PM

  • Validation error message

Screenshot_2023-07-05_at_3.19.07_PM

How to set up and validate locally

  1. Simulate SaaS
  2. Turn on the feature flag by going to rails console and run Feature.enable(:prevent_visibility_restriction)
  3. Log in as admin
  4. Go to /admin/application_settings/general#js-visibility-settings
  5. Select Internal under Default group visibility
  6. Check Internal under Restricted visibility levels
  7. Submit the form

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Roy Liu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading