Skip to content

No longer support auto approval for deployment

What does this MR do and why?

Related issue: #391258 (comment 1382620800)

Related Jihu epic: https://jihulab.com/groups/gitlab-cn/-/epics/5413

We introduced a feature in #381418 (closed) before: if user checks the checkbox below, we "Allow pipeline triggerer to approve deployment", and the approval is automatically done for the user.

The current MR will modify this - the approve operation will no longer be automatically done.

Screenshots or screen recordings

Before After

How to set up and validate locally

  1. Follow the documentation to create a protected environment
  2. When the "Allow pipeline triggerer to approve deployment." checkbox is checked, push commits to trigger a new Deployment task.
    Expect no Approvals to be automatically added

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.


cc @mtan-gitlab @icbd

Edited by Zhiyuan Lu

Merge request reports