Separate deployment approvals checkbox setting (one is for allow and one is for automating)

Details

The following discussion from !111220 (closed) should be addressed.

Split the approval options setting into 2 distinct settings:

  • Allow pipeline triggerers to approve their own deployments
  • Enable automatic approval for deployments where the triggerer is allowed to approve

This would help solve internal and external user problems right now:

But doing the approval automatically is a completely different thing from allowing me to perform a manual step which I wasn't allowed to perform otherwise. Personally it seems very counter-intuitive to me. Coupling these two things made the new featue unusable for some customers who were hoping to get the "Allow" functionality – but while they do want to allow the triggerer to approve the deployment, they very much still want it to be a manual process.

Proposal

Figma

Screenshot_2023-03-01_at_1.26.25_PM

Edited by Emily Bauman