Skip to content

refactor: Move shared runners group logic to service

Vladimir Shushlin requested to merge vshushlin/group-shared-runner-service-refactoring into master

What does this MR do and why?

There's quite a lot code in the Group class which is only used in UpdateSharedRunnersService and actually belongs to that class.

This MR moves this code to the service with all associated tests.

These methods aren't used anywhere else, and there are no behavioral changes - it's a pure refactoring.

It's groundwork for Re-enable shared runners for sub-groups and pro... (#299823 - closed)

How to set up and validate locally

  1. Setup a hierarchy parent group -> group -> project
  2. play around with group and project setting for shared runners.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vladimir Shushlin

Merge request reports