Remove custom_roles_vulnerability feature flag
What does this MR do and why?
It removes the custom_roles_vulnerability
feature flag.
The FF was enabled by default in %16.1 and now we can remove it.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #415662 (closed)
Merge request reports
Activity
changed milestone to %16.2
assigned to @jarka
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tianwen Chen (
@tianwenchen
) (UTC+8, 6 hours ahead of@jarka
)Rajendra Kadam (
@rkadam3
) (UTC+5.5, 3.5 hours ahead of@jarka
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@080fc8f1
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 56b8f9c8expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 1 | 0 | 0 | 0 | 1 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 56b8f9c8expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 174 | 1 | 31 | 10 | 206 | ❌ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Create | 151 | 0 | 39 | 2 | 190 | ❗ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 350 | 1 | 72 | 12 | 423 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Drew Blessing
@tachyons-gitlab could you please review?
requested review from @tachyons-gitlab
@tachyons-gitlab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @tachyons-gitlab
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@fedb8367
- Resolved by Jessie Young
@jarka, please can you answer the question: Should this have a feature flag? to help with code review for the Authentication and Authorization group.This nudge was added by this triage-ops policy.
requested review from @dblessing
- Resolved by Jessie Young
@jarka This also affects self-managed? Is one milestone enough time to discern whether there are any problems with the feature? If there's a risk of problems for self-managed post-upgrade we may want to wait at least another milestone in case of problems.
requested review from @jessieay
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@b6af0094
- Resolved by Jessie Young
@jessieay so are we good to go? Can we merge this? Just making sure
enabled an automatic merge when the pipeline for f470e51a succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@f470e51a
mentioned in commit 1a0a1c41
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2281 (merged)
added releasedpublished label and removed releasedcandidate label