Ignore ci_default_git_depth parameter for project creation endpoint

What does this MR do and why?

The ci_default_git_depth parameter was included among the declared parameters for project creation. This is not actually supported and would result in the ci_cd_setting association being loaded before being created. With the ci_cd_setting not being created as a result.

Instead we ignore the ci_default_git_depth parameter during create by moving it to the update parameters.

Contributes to: #393502 (closed)

How to set up and validate locally

1. Try creating a project through the API (Something like curl -XPOST 'http://gdk.test:3000/api/v4/projects' --header "PRIVATE-TOKEN: token" --header "Content-Type: application/json" --data '{"name": "test-settings", "namespace_id": 1, "ci_default_git_depth": 1}') and see that the project is created and the ci_default_git_depth parameter is ignored
2. Try to change ci/cd settings for the project (Settings -> CI/CD) that exist on the ci_cd_setting association. For example Keep artifacts from most recent successful jobs or Git shallow clone. There should be no unexpected errors here.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #393502 (closed)

changed milestone to %16.2

added Category:Source Code Management Deliverable SLOMissed automation:ml automation:self-triage-encouraged backend bugfunctional candidate16.2 customer devopscreate groupsource code priority2 reproduced on GitLab.com sectiondev severity2 typebug workflowready for development labels

assigned to @j.seto

	1 Warning
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Joseph Joshua (@joseph) (UTC+0, 4 hours ahead of @j.seto)	Vasilii Iakliushin (@vyaklushin) (UTC+2, 6 hours ahead of @j.seto)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

@j.seto Some end-to-end (E2E) tests have been selected based on the stage label on this MR. If not run already, please run the e2e:package-and-test-ee job in the qa stage and review the results before merging this MR. (E2E tests are not run automatically on some MRs due to runner resource constraints.)

If you would like to run all e2e tests, please apply the pipeline:run-all-e2e label and restart the pipeline.

Once done, please apply the emoji on this comment.

For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 6c26c2d1

expand test summary

+-------------------------------------------------------------+
|                       suites summary                        |
+--------+--------+--------+---------+-------+-------+--------+
|        | passed | failed | skipped | flaky | total | result |
+--------+--------+--------+---------+-------+-------+--------+
| Create | 8      | 0      | 1       | 6     | 9     | ❗     |
+--------+--------+--------+---------+-------+-------+--------+
| Total  | 8      | 0      | 1       | 6     | 9     | ❗     |
+--------+--------+--------+---------+-------+-------+--------+

changed the description

marked this merge request as ready

hi @hraghuvanshi could you do the initial review for this?

requested review from @hraghuvanshi

removed review request for @hraghuvanshi

added 418 commits

• 9f3899cb...eff00776 - 417 commits from branch master
• 6fbe6c1c - Ignore ci_default_git_depth parameter for project creation endpoint

Compare with previous version

changed the description

requested review from @hraghuvanshi

removed review request for @hraghuvanshi

mentioned in merge request !124222 (closed)

requested review from @hraghuvanshi

approved this merge request

requested review from @ashmckenzie and removed review request for @hraghuvanshi