Skip to content

Fix some vulnerability report filter placeholders

What does this MR do and why?

Due to a recent change in another MR, the placeholders were removed, but we need to still pass them to the getSelectedTextOptions util.

It's now fixed for the 3 filters or which the placeholders were not appearing:

  • image filter
  • cluster filter
  • activity filter

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-06-16_at_10.46.08 Screenshot_2023-06-16_at_10.45.48

How to set up and validate locally

Prerequisites

  1. You'll need an EE license
  2. You'll need to have runners enabled (See $2408961 for setting up a runner)
  3. Import https://gitlab.com/gitlab-examples/security/security-reports
  4. Run a pipeline on master

Validate

  1. Go to the vulnerability report of security-reports project
  2. Validate that by default (when no option is selected), the activity filter on the "Development vulnerabilities" tab and the cluster filter and images filter on the "Operational vulnerabilities" tab all have a placeholder.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lorenz van Herwaarden

Merge request reports

Loading