Skip to content
Snippets Groups Projects

Place the all mention autocompletion behind FF

Merged euko requested to merge 415523-remove-all-from-autocompletion into master

What does this MR do and why?

For task #415523 (closed) and issue #18442 (closed).

When disable_all_mention is enabled @all should not appear in the autocompletion lists.

How to set up and validate locally

Visit the autocompletion route with/without the feature flag disable_all_mention enabled:

For project autocompletion:

http://<your gdk addr>/gitlab-org/gitlab-test/-/autocomplete_sources/members?type=Issue&type_id=3

For group autocompletion:

http://<your gdk addr>/groups/gitlab-org/-/autocomplete_sources/members?type=Epic&type_id=1

When the FF is enabled, expect to not see the @All item. The sorting of the autocompleted items happen on the frontend so you might have to search for a second or two. For the project autocompletion route, name should be All Project and Group Members.

- {
- "username": "all",
- "name": "All Group Members",
- "count": 11
- },

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by euko

Merge request reports

Merged results pipeline #905649282 passed

Pipeline: GitLab

#905658342

    Pipeline: E2E GDK

    #905690193

      Merged results pipeline passed for 0ec32727

      Test coverage 82.28% (15.60%) from 2 jobs

      Merged by Pavel ShutsinPavel Shutsin 1 year ago (Jun 20, 2023 11:31pm UTC)

      Loading

      Pipeline #906289943 passed

      Pipeline passed for 200cebcf on master

      Test coverage 66.73% (15.60%) from 2 jobs
      10 environments impacted.

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      Please register or sign in to reply
      Loading