Hide pipeline duration use-case - UX adjustment
What does this MR do and why?
UX adjustment for pipeline details header refactor (behind flag pipeline_details_header_vue
).
Use-case fix for when a user has cancelled a pipeline and then retries the pipeline putting it in a running state. Previously the finished duration was showing because the old duration is still present in the payload.
First MR: !120634 (merged)
Second MR: !121174 (merged)
Third MR: !122216 (merged)
Fourth MR (removal): !122516 (merged)
Design can be found here #394768[Unbox-pipeline-detail-page.png]
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Enable
pipeline_details_header_vue
in the rails console - Run a pipeline then cancel it
- Retry that same pipeline putting it in a running state
- Verify duration is not shown while that pipeline is running
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #394768 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @pburdette
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Deepika Guliani (
@deepika.guliani
) (UTC+5.5, 9.5 hours ahead of@pburdette
)Lukas Eipert (
@leipert
) (UTC+2, 6 hours ahead of@pburdette
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger @pburdette Some end-to-end (E2E) tests have been selected based on the stage label on this MR. If not run already, please run thee2e:package-and-test-ee
job in theqa
stage and review the results before merging this MR. (E2E tests are not run automatically on some MRs due to runner resource constraints.)If you would like to run all e2e tests, please apply the pipeline:run-all-e2e label and restart the pipeline.
Once done, please apply the
emoji on this comment.For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 2e8811a5 and 4cd1ce12
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.12 MB 4.12 MB - 0.0 % mainChunk 3 MB 3 MB - 0.0 %
Note: We do not have exact data for 2e8811a5. So we have used data from: d22cd27c.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerHey @jivanvl would you mind taking a look at this small MR?
requested review from @jivanvl
added maintenancerefactor label
added feature flagexists label
enabled an automatic merge when the pipeline for 241e30bd succeeds
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 4cd1ce12expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 4cd1ce12expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 30 | 0 | 3 | 1 | 33 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in commit 8a603862
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label