Enable new navigation per default for logged-in users
What does this MR do and why?
Enable new navigation per default for logged-in users
Previously logged-in users needed to opt-in to the new navigation. Now we are making it the default and we enable them to opt-out.
Changelog: changed
Screenshots or screen recordings
N/A
How to set up and validate locally
N/A
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #410121 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @leipert
mentioned in issue #410121 (closed)
removed automation:ml wrong label
removed automation:ml label
added Navigation redesign featureenhancement labels
added typefeature label
- Resolved by Christen Dybenko
@thutterer Could you please review?
- Resolved by Olena Horal-Koretska
requested review from @thutterer
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@6cbcf630
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 907f649dexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 907f649dexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Manage | 64 | 2 | 6 | 6 | 72 | ❌ | | Create | 0 | 0 | 10 | 0 | 10 | ➖ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 64 | 2 | 16 | 6 | 82 | ❌ | +--------+--------+--------+---------+-------+-------+--------+
@thutterer
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c9786b61
requested review from @ohoral and removed review request for @thutterer