Adjust the width of status column in admin jobs table
What does this MR do and why?
This MR wants to make the final adjustments in order to rollout the FF for the filtering of the admin jobs page, see #391194 (comment 1400285958) and !117362 (comment 1390015201) .
The MR adjusts the width of column Status
in admin jobs table. There was a small styling issue that lead to overlapping content
between the column Status
and the column Job
in the admin jobs page.
Screenshots or screen recordings
-
I adjusted and chose a better column width for the column Status
on the left-hand side (gl-w-15p
instead ofgl-w-10p
), see job with the id334
and the statuscanceled
in the middle of the table -
I removed the column Coverage
in order to reduce the cluttered table => I made an educated guess that the columnCoverage
is not necessary in the admin jobs page
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- In rails console enable the experiment fully
Feature.enable(:admin_jobs_vue)
- Go to
Admin > CI/CD > Jobs
- In rails console, ensure that at least one job has the status canceled
Ci::Build.find(334).update(status: :cancel)
- When you test different screensizes then you should see that there are no overlaps between the column
Status
and the columnJob
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR. -
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
Related to #22626 (closed)
Merge request reports
Activity
added typefeature label
added Leading Organization label
Hey @gerardo-navarro!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @gerardo-navarro
added linked-issue label
4 Warnings This merge request does not refer to an existing milestone. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Please add a merge request subtype to this merge request. This Merge Request needs to be labelled with frontend. Please request a reviewer or maintainer to add them. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Ankit Panchal (
@ankit.panchal
) (UTC+5.5)Michael Lunøe (
@mlunoe
) (UTC+2)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Jose Ivan Vargas
marked the checklist item Tested in all supported browsers as incomplete
mentioned in issue #391194 (closed)
mentioned in merge request !117362 (closed)
- Resolved by Jose Ivan Vargas
mentioned in issue gitlab-org/quality/triage-reports#12795 (closed)
marked the checklist item Tests added for this feature/bug as completed