Skip to content

Adjust the width of status column in admin jobs table

Gerardo Navarro requested to merge gitlab-community/gitlab:22626-feat-add-filter-on-jobs-page-in-admin-area-style-fix-fixed-width-for-status-column into master

What does this MR do and why?

This MR wants to make the final adjustments in order to rollout the FF for the filtering of the admin jobs page, see #391194 (comment 1400285958) and !117362 (comment 1390015201) .

The MR adjusts the width of column Status in admin jobs table. There was a small styling issue that lead to overlapping content between the column Status and the column Job in the admin jobs page.

🛠 with ❤ at Siemens

Screenshots or screen recordings

  • I adjusted and chose a better column width for the column Status on the left-hand side (gl-w-15p instead of gl-w-10p), see job with the id 334 and the status canceled in the middle of the table
  • I removed the column Coverage in order to reduce the cluttered table => I made an educated guess that the column Coverage is not necessary in the admin jobs page
Before After
grafik grafik

How to set up and validate locally

  1. In rails console enable the experiment fully
Feature.enable(:admin_jobs_vue)
  1. Go to Admin > CI/CD > Jobs
  2. In rails console, ensure that at least one job has the status canceled
Ci::Build.find(334).update(status: :cancel)
  1. When you test different screensizes then you should see that there are no overlaps between the column Status and the column Job

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #22626 (closed)

Edited by Gerardo Navarro

Merge request reports