Remove inline_haml_diff_line_rendering feature flag
What does this MR do and why?
Removes inline_haml_diff_line_rendering
feature flag, a marginal speed improvement for diff line rendering. This has been enabled on production for over a year.
Changelog: performance
Closes #330582
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.1
assigned to @robotmay_gitlab
- A deleted user
added backend bugperformance frontend typebug labels
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Thomas Hutterer (
@thutterer
) (UTC+2, 1 hour ahead of@robotmay_gitlab
)Kassio Borges (
@kassio
) (UTC+1, same timezone as@robotmay_gitlab
)frontend Lorenz van Herwaarden (
@lorenzvanherwaarden
) (UTC+2, 1 hour ahead of@robotmay_gitlab
)Lukas Eipert (
@leipert
) (UTC+2, 1 hour ahead of@robotmay_gitlab
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@8009375b
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 6fa20f34expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 6fa20f34expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 248 | 2 | 25 | 0 | 275 | ❌ | | Create | 688 | 0 | 117 | 5 | 805 | ❗ | | Plan | 390 | 0 | 3 | 0 | 393 | ✅ | | Fulfillment | 12 | 0 | 125 | 0 | 137 | ✅ | | Govern | 245 | 0 | 5 | 0 | 250 | ✅ | | Data Stores | 185 | 0 | 3 | 0 | 188 | ✅ | | Secure | 10 | 0 | 45 | 0 | 55 | ✅ | | Monitor | 52 | 0 | 11 | 0 | 63 | ✅ | | Package | 162 | 0 | 15 | 141 | 177 | ❗ | | Manage | 223 | 1 | 17 | 12 | 241 | ❌ | | Systems | 19 | 0 | 0 | 0 | 19 | ✅ | | Release | 30 | 0 | 0 | 0 | 30 | ✅ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | Analytics | 11 | 0 | 0 | 0 | 11 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Framework sanity | 0 | 0 | 7 | 0 | 7 | ➖ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2278 | 3 | 404 | 158 | 2685 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Justin Ho Tuan Duong
requested review from @justin_ho and removed review request for @janis
@janis
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@ca107c6d
- Resolved by Justin Ho Tuan Duong
enabled an automatic merge when the pipeline for ca107c6d succeeds
mentioned in commit cdd05f5b
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
added releasedpublished label and removed releasedcandidate label