Allow writing text in angle brackets
What does this MR do and why?
Allow writing text in angle brackets
In content editor, allow writing prose that looks like code. So, typing should work fine by escaping the < and > in the text by adding backslashes.
Changelog: changed
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
Screen_Recording_2023-06-10_at_01.05.29 | Screen_Recording_2023-06-10_at_01.05.09 |
How to set up and validate locally
- Edit a wiki page
- Switch to rich text editor.
- Enter some content in angle brackets like
<this>
. - Switch to markdown and back to rich text.
- Notice that
<this>
is retained because it was escaped with backslashes. Previously it would disappear.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #336543 (closed)
Merge request reports
Activity
changed milestone to %Backlog
assigned to @himkp
removed [deprecated] Accepting merge requests label
removed direction label
removed documentation label
removed Content EditorPost GA label
added Content EditorGA label
mentioned in issue #336543 (closed)
- A deleted user
added frontend label
1 Warning Please add a merge request subtype to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Stanislav Lashmanov (
@slashmanov
) (UTC+4, 2 hours ahead of@himkp
)Peter Hegman (
@peterhegman
) (UTC-7, 9 hours behind@himkp
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 75eee352 and 79a32c75
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.11 MB 4.11 MB - 0.0 % mainChunk 2.99 MB 2.99 MB - 0.0 %
Note: We do not have exact data for 75eee352. So we have used data from: 4ff35974.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 79a32c75expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 79a32c75expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 79a32c75expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Verify | 250 | 0 | 25 | 0 | 275 | ✅ | | Create | 688 | 0 | 117 | 5 | 805 | ❗ | | Plan | 385 | 0 | 3 | 0 | 388 | ✅ | | Fulfillment | 12 | 0 | 125 | 0 | 137 | ✅ | | Package | 162 | 0 | 15 | 141 | 177 | ❗ | | Framework sanity | 0 | 0 | 7 | 0 | 7 | ➖ | | Manage | 222 | 2 | 17 | 14 | 241 | ❌ | | Govern | 245 | 0 | 5 | 10 | 250 | ❗ | | Data Stores | 185 | 0 | 3 | 0 | 188 | ✅ | | Secure | 10 | 0 | 45 | 0 | 55 | ✅ | | Analytics | 11 | 0 | 0 | 0 | 11 | ✅ | | Monitor | 52 | 0 | 11 | 0 | 63 | ✅ | | Systems | 19 | 0 | 0 | 0 | 19 | ✅ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | Release | 30 | 0 | 0 | 0 | 30 | ✅ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2274 | 2 | 404 | 170 | 2680 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
@kushalpandya Mind reviewing this one as well as it is related somewhat to !123216 (merged)? Thanks
Edited by Himanshu Kapoorrequested review from @kushalpandya