Fix OIDC account linking from profile
What does this MR do and why?
Fixes (Re)Connect to OIDC failed with "uninitialized ... (#411288 - closed)
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Setup omniauth provider for openid_connect
- Go-to
-/profile/account
- Click on
Connect open id connect
- Make sure that page is not showing any error
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @tachyons-gitlab
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Jerry Seto (
@j.seto
) (UTC-4, 9.5 hours behind@tachyons-gitlab
)Doug Stull (
@dstull
) (UTC-4, 9.5 hours behind@tachyons-gitlab
)~"group::authentication and authorization" Reviewer review is optional for ~"group::authentication and authorization" Jarka Košanová (
@jarka
) (UTC+2, 3.5 hours behind@tachyons-gitlab
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #411288 (closed)
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@tachyons-gitlab - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for cc3e61c3expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for cc3e61c3expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Package | 268 | 0 | 49 | 228 | 317 | ❗ | | Create | 688 | 0 | 117 | 5 | 805 | ❗ | | Plan | 390 | 0 | 3 | 0 | 393 | ✅ | | Data Stores | 185 | 0 | 3 | 0 | 188 | ✅ | | Govern | 243 | 2 | 10 | 5 | 255 | ❌ | | Manage | 206 | 19 | 17 | 29 | 242 | ❌ | | Secure | 10 | 0 | 45 | 0 | 55 | ✅ | | Fulfillment | 12 | 0 | 125 | 0 | 137 | ✅ | | Verify | 250 | 0 | 25 | 0 | 275 | ✅ | | Release | 30 | 0 | 0 | 0 | 30 | ✅ | | Monitor | 52 | 0 | 11 | 0 | 63 | ✅ | | Systems | 19 | 0 | 0 | 0 | 19 | ✅ | | Framework sanity | 0 | 0 | 7 | 0 | 7 | ➖ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | Analytics | 11 | 0 | 0 | 0 | 11 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2367 | 21 | 443 | 267 | 2831 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
@tachyons-gitlab, please can you answer the question: Should this have a feature flag? to help with code review for the Authentication and Authorization group.This nudge was added by this triage-ops policy.
Setting label(s) devopsmanage sectiondev based on ~"group::authentication and authorization".
added devopsmanage sectiondev labels
added bugfunctional label
added typebug label
requested review from @ifarkas
- Resolved by Jessie Young
@ifarkas Could you review this for ~"group::authentication and authorization"
added workflowin dev label
- Resolved by Aboobacker MK
@tachyons-gitlab Some end-to-end (E2E) tests have been selected based on the stage label on this MR. If not run already, please run thee2e:package-and-test-ee
job in theqa
stage and review the results before merging this MR. (E2E tests are not run automatically on some MRs due to runner resource constraints.)If you would like to run all e2e tests, please apply the pipeline:run-all-e2e label and restart the pipeline.
Once done, please apply the
emoji on this comment.For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.
changed milestone to %16.1
@dstull
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
added pipeline:run-all-e2e label
enabled an automatic merge when the pipeline for dc8a3c46 succeeds
mentioned in commit bb908bbf
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
added releasedpublished label and removed releasedcandidate label