Skip to content
Snippets Groups Projects

Fine tune over limit email notification worker

Merged Doug Stull requested to merge 413547-update-notification-query into master
All threads resolved!

What does this MR do and why?

Fine tune over limit email notification worker as current method times out for sql statements - see https://gitlab.com/gitlab-org/gitlab/-/issues/413547#note_1422454511

As per !118906 (comment 1420459287)

  • Remove skip locked since we only use one worker with a 24hr buffer
  • Use read replica for reads
  • load the namespace_details in a separate query

Database

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #413547

Edited by Doug Stull

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • approved this merge request

  • :wave: @syarynovskyi, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • requested review from @mcelicalderonG and removed review request for @syarynovskyi

  • Vitali Tatarintev approved this merge request

    approved this merge request

  • Vitali Tatarintev requested review from @ahegyi and removed review request for @ck3g

    requested review from @ahegyi and removed review request for @ck3g

  • Doug Stull added 1 commit

    added 1 commit

    • c4a3c017 - Update per review suggestion

    Compare with previous version

  • Mario Celi approved this merge request

    approved this merge request

  • Adam Hegyi approved this merge request

    approved this merge request

  • added databaseapproved label and removed databasereviewed label

  • Adam Hegyi resolved all threads

    resolved all threads

  • Adam Hegyi enabled an automatic merge when the pipeline for f88d7d3a succeeds

    enabled an automatic merge when the pipeline for f88d7d3a succeeds

  • merged

  • Hello @dstull :wave:

    The database team is looking for ways to improve the database review process and we would love your help!

    If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

    @gitlab-org/database-team

    And someone will be by shortly!

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Adam Hegyi mentioned in commit 18fd42fe

    mentioned in commit 18fd42fe

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading