Skip to content
Snippets Groups Projects

Enable deleting_account_disabled_for_users by default

Merged Jarka Košanová requested to merge 412411-enable-ff-default into master
All threads resolved!

What does this MR do and why?

We introduced the FF in !117832 (merged) and enabled it globally on May 30th.

This MR sets the FF enabled by default.

How to set up and validate locally

  1. Sign in as a user A.
  2. Go to the Preferences -> Account, click Delete account.
  3. You can delete the account A.
  4. Open another browser window and sign in with admin account.
  5. Go to Admin -> General -> Account and limit section.
  6. Uncheck the checkbox Allows users to delete their own accounts and click Save changes.
  7. Go back to the browser window with user B.
  8. Go to the Preferences -> Account, click Delete account.
  9. You cannot find the Delete account section.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #412411 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor
    2 Warnings
    :warning: This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.
    :warning: Please add a merge request subtype to this merge request.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for 62b2b716

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :exclamation: test report for 62b2b716

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Manage | 66     | 0      | 6       | 4     | 72    | ❗     |
    | Create | 0      | 0      | 10      | 0     | 10    | ➖     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 66     | 0      | 16      | 4     | 82    | ❗     |
    +--------+--------+--------+---------+-------+-------+--------+
  • Adil Farrukh resolved all threads

    resolved all threads

  • Adil Farrukh approved this merge request

    approved this merge request

  • :wave: @adil.farrukh, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Author Maintainer

    @dblessing could you please review as a maintainer?

  • Jarka Košanová requested review from @dblessing

    requested review from @dblessing

  • Adil Farrukh resolved all threads

    resolved all threads

  • Drew Blessing approved this merge request

    approved this merge request

  • merged

  • @dblessing, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to merge when pipeline succeeds.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • Drew Blessing mentioned in commit 91075988

    mentioned in commit 91075988

  • Merging as I understand the allow_account_deletion application setting is true by default and we have no intention of disabling this for .com. This is default-enabling the feature flag for self-managed, but where the setting also defaults to true so default behavior for self-managed installation is also unchanged.

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #412411 (closed)

  • Jarka Košanová mentioned in merge request !124052 (merged)

    mentioned in merge request !124052 (merged)

  • Please register or sign in to reply
    Loading