Enable deleting_account_disabled_for_users by default
What does this MR do and why?
We introduced the FF in !117832 (merged) and enabled it globally on May 30th.
This MR sets the FF enabled by default.
How to set up and validate locally
- Sign in as a user
A
. - Go to the
Preferences
->Account
, clickDelete account
. - You can delete the account
A
. - Open another browser window and sign in with admin account.
- Go to
Admin
->General
->Account and limit
section. - Uncheck the checkbox
Allows users to delete their own accounts
and clickSave changes
. - Go back to the browser window with user
B
. - Go to the
Preferences
->Account
, clickDelete account
. - You cannot find the
Delete account
section.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #412411 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @jarka
mentioned in merge request gitlab-com/www-gitlab-com!123826 (merged)
- Resolved by Adil Farrukh
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.Please add a merge request subtype to this merge request. If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 62b2b716expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 62b2b716expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Manage | 66 | 0 | 6 | 4 | 72 | ❗ | | Create | 0 | 0 | 10 | 0 | 10 | ➖ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 66 | 0 | 16 | 4 | 82 | ❗ | +--------+--------+--------+---------+-------+-------+--------+
@adil.farrukh
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@2c53bf45
@dblessing could you please review as a maintainer?
requested review from @dblessing
- Resolved by Adil Farrukh
@jarka, please can you answer the question: Should this have a feature flag? to help with code review for the Authentication and Authorization group.This nudge was added by this triage-ops policy.
@dblessing, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 91075988
Merging as I understand the
allow_account_deletion
application setting istrue
by default and we have no intention of disabling this for .com. This is default-enabling the feature flag for self-managed, but where the setting also defaults to true so default behavior for self-managed installation is also unchanged.added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue #412411 (closed)
mentioned in merge request !124052 (merged)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
added releasedpublished label and removed releasedcandidate label