Skip to content

Fix memory leak in CI config includes entry

Stan Hu requested to merge gb-fix-slow-ci-config-16-0 into 16-0-stable-ee

What does this MR do and why?

This backports !122462 (merged) to 16-0-stable-ee.

In GitLab 11.9, gitlab-foss!24098 (merged) introduced validation of include keywords. However, it quietly introduced a memory leak: any time a new include entry was instantiated, a proc would be added to the aspects class variable. As the list grew, the time taken to process other include keywords would grow.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The original MR has been deployed to (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:package-and-test-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Stan Hu

Merge request reports