Skip to content
Snippets Groups Projects

Fix memory leak in CI config includes entry

All threads resolved!

What does this MR do and why?

This merge request attempts to fix a memory / objects leak related to using includes: keyword in CI configuration. The leak has been introduced in 30791a36 a couple of years ago.

Investigation MR with profiler / benchmarks and some insights: !122437 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Grzegorz Bizon

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • mentioned in issue #413143 (closed)

  • Furkan Ayhan changed milestone to %16.1

    changed milestone to %16.1

  • Grzegorz Bizon requested review from @furkanayhan

    requested review from @furkanayhan

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for 78206416

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Furkan Ayhan marked this merge request as ready

    marked this merge request as ready

  • Grzegorz Bizon changed the description

    changed the description

  • Grzegorz Bizon mentioned in merge request !122294 (closed)

    mentioned in merge request !122294 (closed)

  • Grzegorz Bizon
  • Stan Hu added 1 commit

    added 1 commit

    • 8700fef0 - Add unit test for ::Gitlab::Ci::Config::Entry::Includes#initialize

    Compare with previous version

  • Furkan Ayhan removed review request for @furkanayhan

    removed review request for @furkanayhan

  • Stan Hu added 353 commits

    added 353 commits

    Compare with previous version

  • Stan Hu mentioned in merge request !122539 (merged)

    mentioned in merge request !122539 (merged)

  • Stan Hu mentioned in merge request !122540 (merged)

    mentioned in merge request !122540 (merged)

  • Stan Hu mentioned in merge request !122541 (merged)

    mentioned in merge request !122541 (merged)

  • Stan Hu requested review from @furkanayhan

    requested review from @furkanayhan

  • Grzegorz Bizon marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Peter Leitzen requested review from @splattael

    requested review from @splattael

  • Peter Leitzen approved this merge request

    approved this merge request

  • :wave: @splattael, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Peter Leitzen resolved all threads

    resolved all threads

  • Grzegorz Bizon requested review from @ayufan

    requested review from @ayufan

  • Kamil Trzciński approved this merge request

    approved this merge request

  • Kamil Trzciński removed review request for @ayufan

    removed review request for @ayufan

  • Peter Leitzen resolved all threads

    resolved all threads

  • Peter Leitzen resolved all threads

    resolved all threads

  • merged

  • Peter Leitzen mentioned in commit 4f3225e5

    mentioned in commit 4f3225e5

  • added workflowstaging label and removed workflowcanary label

  • Ben Prescott_ mentioned in merge request !122631 (closed)

    mentioned in merge request !122631 (closed)

  • Grzegorz Bizon mentioned in issue #415051

    mentioned in issue #415051

  • Furkan Ayhan mentioned in issue #413029

    mentioned in issue #413029

  • 🤖 GitLab Bot 🤖 added sectionci label and removed sectionops label

    added sectionci label and removed sectionops label

  • Ben Prescott_ mentioned in merge request !147532 (closed)

    mentioned in merge request !147532 (closed)

  • Please register or sign in to reply
    Loading