Skip to content
Snippets Groups Projects

Fix delete "Severity" criteria from Security Policy rule

Merged Artur Fedorov requested to merge 413712-srp-severity-filter-delete into master
All threads resolved!

What does this MR do and why?

This MR resolves 413712

Problem:

  • It was impossible to delete "Severity" criteria from Security Policy rule for existing policies

Outcome:

  • It is now ipossible to delete "Severity" criteria from Security Policy rule for existing policies

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

DESCRIPTION VIDEO
BEFORE https://www.loom.com/share/a60f884828644ce0abf6af62ab5ef61a
NEW Project new_project
EXISTING Project existing_project
EXISTING Group group_existing

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Go to project or group
  2. Secure -> Policies
  3. Create new scan result policy if there are none or add severity criteria to existing
  4. Edit policy and try to click trash icon and remove severity criteria.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #413712 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rahul Chanila
  • Artur Fedorov added 181 commits

    added 181 commits

    Compare with previous version

  • Artur Fedorov mentioned in merge request !122470 (closed)

    mentioned in merge request !122470 (closed)

  • Rahul Chanila approved this merge request

    approved this merge request

  • Rahul Chanila requested review from @ohoral and removed review request for @rchanila

    requested review from @ohoral and removed review request for @rchanila

  • :wave: @rchanila, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Camellia X Yang approved this merge request

    approved this merge request

  • Camellia X Yang removed review request for @cam.x

    removed review request for @cam.x

  • Artur Fedorov added 391 commits

    added 391 commits

    Compare with previous version

  • Olena Horal-Koretska approved this merge request

    approved this merge request

  • Olena Horal-Koretska resolved all threads

    resolved all threads

  • Olena Horal-Koretska enabled an automatic merge when the pipeline for 88753d60 succeeds

    enabled an automatic merge when the pipeline for 88753d60 succeeds

  • mentioned in commit c7632943

  • Artur Fedorov resolved all threads

    resolved all threads

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading