Fix delete "Severity" criteria from Security Policy rule
What does this MR do and why?
This MR resolves 413712
Problem:
- It was impossible to delete "Severity" criteria from Security Policy rule for existing policies
Outcome:
- It is now ipossible to delete "Severity" criteria from Security Policy rule for existing policies
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
DESCRIPTION | VIDEO |
---|---|
BEFORE | https://www.loom.com/share/a60f884828644ce0abf6af62ab5ef61a |
NEW Project | new_project |
EXISTING Project | existing_project |
EXISTING Group | group_existing |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Go to
project
orgroup
-
Secure
->Policies
- Create new
scan result policy
if there are none or addseverity
criteria to existing - Edit policy and try to click
trash
icon and removeseverity
criteria.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #413712 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @arfedoro
added workflowin review label
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
added bugfunctional label
mentioned in issue #413712 (closed)
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Minahil Nichols (
@minahilnichols
) (UTC-4, 6 hours behind@arfedoro
)Paul Slaughter (
@pslaughter
) (UTC-5, 7 hours behind@arfedoro
)UX Michael Le (
@mle
) (UTC+10, 8 hours ahead of@arfedoro
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Olena Horal-Koretska
requested review from @cam.x
- Resolved by Artur Fedorov
requested review from @rchanila
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 59970b7c and 25a156d9
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.13 MB 4.13 MB - 0.0 % mainChunk 2.98 MB 2.98 MB - 0.0 %
Note: We do not have exact data for 59970b7c. So we have used data from: 3568ce16.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 25a156d9expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 25a156d9expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 21 | 0 | 0 | 0 | 21 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 39 | 0 | 3 | 1 | 42 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Artur Fedorov
- Resolved by Artur Fedorov
- Resolved by Artur Fedorov
ux(non-blocking): This is probably the underlying component but we can notice the padding change when an option is selected/deselected
added 181 commits
-
5f48dd61...fc791686 - 179 commits from branch
master
- d3d2bc88 - This MR fixes deletion of severity filter
- 9a79b742 - Applied review changes
-
5f48dd61...fc791686 - 179 commits from branch
mentioned in merge request !122470 (closed)
@rchanila
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Olena Horal-Koretska
removed review request for @cam.x
added 391 commits
-
9a79b742...73daacce - 389 commits from branch
master
- 545c8726 - This MR fixes deletion of severity filter
- 25a156d9 - Applied review changes
-
9a79b742...73daacce - 389 commits from branch
enabled an automatic merge when the pipeline for 88753d60 succeeds
mentioned in commit c7632943
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
added releasedpublished label and removed releasedcandidate label