[Feature flag] Cleanup super_sidebar_nav feature flag
What does this MR do and why?
Removes the super_sidebar_nav
feature flag and its usage in the codebase.
The FF was set to default_enabled: true
for %16.0 and can be removed now.
Screenshots or screen recordings
No changes.
How to set up and validate locally
There shouldn't be any changes. Just verify that the New navigation toggle (in your user dropdown) still works and you can toggle between old and new nav.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #381456 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @thutterer
mentioned in issue #381456 (closed)
- A deleted user
added backend documentation frontend labels
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/development/navigation_sidebar.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Dominic Bauer (
@bauerdominic
) (UTC+2, same timezone as@thutterer
)Roy Zwambag (
@rzwambag
) (UTC+2, same timezone as@thutterer
)frontend Alper Akgun (
@a_akgun
) (UTC+3, 1 hour ahead of@thutterer
)Paul Gascou-Vaillancourt (
@pgascouvaillancourt
) (UTC-4, 6 hours behind@thutterer
)test for spec/features/*
Andrejs Cunskis (
@acunskis
) (UTC+3, 1 hour ahead of@thutterer
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c396cc52
- Resolved by Andrejs Cunskis
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for c742606dexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for c742606dexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 224 | 0 | 17 | 11 | 241 | ❗ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Create | 16 | 0 | 27 | 0 | 43 | ✅ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 265 | 0 | 46 | 11 | 311 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@20db485a
@acunskis
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @acunskis
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@aaeaaf40
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@3ceddfe9
removed review request for @jarka
enabled an automatic merge when the pipeline for 43484961 succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@43484961
mentioned in commit 4f029dc0
mentioned in merge request !120048 (merged)
added workflowstaging-canary label and removed workflowready for development label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue #410121 (closed)
mentioned in issue #409005 (closed)
mentioned in issue gitlab-org/manage/foundations/team-tasks#268
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
added releasedpublished label and removed releasedcandidate label