Fix MR approval rules sync when disabling scan result policy
What does this MR do and why?
Backport of Fix MR approval rules sync when disabling scan ... (!121888 - merged) to %16.0
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. -
The original MR has been deployed to GitLab.com (not applicable for documentation or spec changes). -
This MR has a severity label assigned (if applicable). -
This MR has been approved by a maintainer (only one approval is required). -
Ensure the e2e:package-and-test-ee
job has either succeeded or been approved by a Software Engineer in Test.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releases
Slack channel (internal only).
Merge request reports
Activity
changed milestone to %15.11
assigned to @sashi_kumar
changed milestone to %16.0
1 Warning The e2e:package-and-test-ee
job needs to succeed or have approval from a Software Engineer in Test.
Read the "QA e2e:package-and-test-ee" section for more details.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Joseph Joshua (
@joseph
) (UTC+0, same timezone as@sashi_kumar
)Heinrich Lee Yu (
@engwan
) (UTC+8, 8 hours ahead of@sashi_kumar
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
QA
e2e:package-and-test-ee
@sashi_kumar, the
package-and-test
job must complete before merging this merge request.*If there are failures on the
package-and-test
pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the#quality
Slack channel.If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded groupsecurity policies label
Allure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for d708d6e5expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 235 | 0 | 0 | 10 | 235 | ❗ | | Create | 16 | 0 | 2 | 0 | 18 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 273 | 0 | 4 | 10 | 277 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Gary Holtz
@garyh Would you mind doing the maintainer review for this backport since you already have context?
requested review from @garyh
mentioned in issue #413077 (closed)
changed milestone to %16.1
added missed:16.0 label
mentioned in merge request !122469 (closed)
- Resolved by Gary Holtz
@garyh
, thanks for approving this merge request.This is the first time the merge request is approved. Please ensure the
e2e:package-and-test-ee
job has succeeded. If there is a failure, a Software Engineer in Test (SET) needs to confirm the failures are unrelated to the merge request. If there's no SET assigned to this team, ask for assistance on the#quality
Slack channel.
mentioned in commit 127c7c1c
mentioned in merge request kubitus-project/kubitus-installer!2179 (merged)