Refactor: user profile page to Vue
What does this MR do and why?
Targeting work item: #393766 (closed)
Part of #389918
/cc @prajnamas @qk44077907 @orozot
Refactor: user profile page to Vue
- Add feature flag for user profile refactoring.
- Apply feature flag to the mount element.
Changelog: added
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
No screenshots here.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added JiHu contribution label
Hey @JeremyWuuuuu!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @JeremyWuuuuu
Hey @JeremyWuuuuu!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added linked-issue label
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Eulyeon K. (
@euko
) (UTC+9)Mikołaj Wawrzyniak (
@mikolaj_wawrzyniak
) (UTC+0)frontend Nataliia Radina (
@nradina
) (UTC+2)Paul Gascou-Vaillancourt (
@pgascouvaillancourt
) (UTC-4)test for spec/features/*
Eulyeon K. (
@euko
) (UTC+9)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@gitlab-bot ready @peterhegman
added workflowready for review label and removed workflowin dev label
requested review from @peterhegman
@peterhegman
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
This message was generated automatically. You're welcome to improve it.
- Resolved by Drew Blessing
- Resolved by Wu Jeremy
- A deleted user
added backend feature flag featureaddition frontend grouptenant scale typefeature labels
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Alex Buijs (
@alexbuijs
) (UTC+2)Igor Drozdov (
@igor.drozdov
) (UTC+2)frontend Mireya Andres (
@mgandres
) (UTC+8)Justin Ho (
@justin_ho
) (UTC+7)test for spec/features/*
Alex Buijs (
@alexbuijs
) (UTC+2)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded devopsdata stores sectioncore platform labels
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@789f6e7f
- Resolved by Drew Blessing
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for fe36c432expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for fe36c432expand test summary
+------------------------------------------------------------+ | suites summary | +-------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------+--------+--------+---------+-------+-------+--------+ +-------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 0 | 0 | 0 | ➖ | +-------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for fe36c432expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
added 407 commits
-
013ab0bd...4f3225e5 - 405 commits from branch
gitlab-org:master
- f8a7ceec - Refactor: user profile page to Vue
- 0182cab9 - Test: stub the newly added FF for testing
-
013ab0bd...4f3225e5 - 405 commits from branch
added 1 commit
- 06a5cd77 - Move FF stub to the start of the before action
added 1 commit
- 544e6219 - Feat: add an empty Vue component for mounting
removed review request for @peterhegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
Hi @peterhegman
We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.
@JeremyWuuuuu you may also request a review by commenting
@gitlab-bot ready
. You can also assign reviewers directly using@gitlab-bot ready @user1 @user2
if you know the relevant reviewer(s), such as those who were involved in a related issue.This message was generated automatically. You're welcome to improve it.
added workflowin dev label and removed workflowready for review label
mentioned in issue gitlab-jh/status-reports#232
@gitlab-bot ready @peterhegman
added workflowready for review label and removed workflowin dev label
requested review from @peterhegman
@peterhegman
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
This message was generated automatically. You're welcome to improve it.
- Resolved by Drew Blessing
Hi @peterhegman, I have addressed the comments you left, and created the rollout issue at rollout_issue_url: #414552, would you mind taking a look at it for me? Thanks in advance!
added 664 commits
-
2a797efc...2ee3031d - 658 commits from branch
gitlab-org:master
- 298e1fac - Refactor: user profile page to Vue
- 8e8fb4a6 - Test: stub the newly added FF for testing
- c65f6b17 - Revert changes in strcuture.sql
- e5c865fc - Move FF stub to the start of the before action
- f0469647 - Feat: add an empty Vue component for mounting
- b08ba785 - Rename feature flag and address MR comments
Toggle commit list-
2a797efc...2ee3031d - 658 commits from branch
- Resolved by Drew Blessing
requested review from @jivanvl and @alexbuijs and removed review request for @peterhegman
- Resolved by Drew Blessing
@peterhegman
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by 🤖 GitLab Bot 🤖
@peterhegman
, thanks for approving this merge request.This is the first time the merge request has been approved. Please wait for AppSec approval before merging.
cc @gitlab-com/gl-security/appsec this is a JiHu contribution, please follow the JiHu contribution review process.
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@6ac6db8a
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 50a976bc and fe36c432
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.11 MB 4.11 MB - 0.0 % mainChunk 2.99 MB 2.99 MB - 0.0 %
Note: We do not have exact data for 50a976bc. So we have used data from: 830415ff.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Greg Alfaro
requested review from @dblessing and removed review request for @alexbuijs
added 385 commits
-
b08ba785...002b472d - 378 commits from branch
gitlab-org:master
- c5389a77 - Refactor: user profile page to Vue
- 22c215c0 - Test: stub the newly added FF for testing
- 247970a3 - Revert changes in strcuture.sql
- e7f4ef95 - Move FF stub to the start of the before action
- dd0bfacc - Feat: add an empty Vue component for mounting
- 56076e86 - Rename feature flag and address MR comments
- fe36c432 - Chore: use safe_format instead of html_safe
Toggle commit list-
b08ba785...002b472d - 378 commits from branch
added sec-planningcomplete label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
enabled an automatic merge when the pipeline for acaa3ddf succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@acaa3ddf
@JeremyWuuuuu, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
mentioned in commit 0c8898c5
changed milestone to %16.1
mentioned in merge request !122971 (merged)
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #389918
mentioned in issue gitlab-jh/status-reports#234
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
mentioned in issue jh-upstream-report#77 (closed)
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-org/quality/triage-reports#15300 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15725 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16030 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16493 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17023 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17471 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17930 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18463 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18942 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19396 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20626 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20971 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21555 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22046