Skip to content
Snippets Groups Projects

Refactor: user profile page to Vue

All threads resolved!

What does this MR do and why?

Targeting work item: #393766 (closed)

Part of #389918

/cc @prajnamas @qk44077907 @orozot

Refactor: user profile page to Vue

  • Add feature flag for user profile refactoring.
  • Apply feature flag to the mount element.

Changelog: added

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

No screenshots here.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Drew Blessing

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Peter Hegman
  • Contributor
    2 Warnings
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    :warning: This merge request does not refer to an existing milestone.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Alex Buijs current availability (@alexbuijs) (UTC+2) Igor Drozdov current availability (@igor.drozdov) (UTC+2)
    frontend Mireya Andres current availability (@mgandres) (UTC+8) Justin Ho current availability (@justin_ho) (UTC+7)
    test for spec/features/* Alex Buijs current availability (@alexbuijs) (UTC+2) Maintainer review is optional for test for spec/features/*

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    • Contributor
      Resolved by Drew Blessing

      Allure report

      allure-report-publisher generated test report!

      e2e-test-on-gdk: :exclamation: test report for fe36c432

      expand test summary
      +-----------------------------------------------------------------------+
      |                            suites summary                             |
      +------------------+--------+--------+---------+-------+-------+--------+
      |                  | passed | failed | skipped | flaky | total | result |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
      | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
      | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
      | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
      | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
      | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
      | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
      +------------------+--------+--------+---------+-------+-------+--------+

      e2e-package-and-test: :heavy_minus_sign: test report for fe36c432

      expand test summary
      +------------------------------------------------------------+
      |                       suites summary                       |
      +-------+--------+--------+---------+-------+-------+--------+
      |       | passed | failed | skipped | flaky | total | result |
      +-------+--------+--------+---------+-------+-------+--------+
      +-------+--------+--------+---------+-------+-------+--------+
      | Total | 0      | 0      | 0       | 0     | 0     | ➖     |
      +-------+--------+--------+---------+-------+-------+--------+

      e2e-review-qa: :exclamation: test report for fe36c432

      expand test summary
      +-----------------------------------------------------------------------+
      |                            suites summary                             |
      +------------------+--------+--------+---------+-------+-------+--------+
      |                  | passed | failed | skipped | flaky | total | result |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
      | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
      | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
      | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
      | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
      | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
      | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Total            | 20     | 0      | 3       | 1     | 23    | ❗     |
      +------------------+--------+--------+---------+-------+-------+--------+
  • Wu Jeremy added 407 commits

    added 407 commits

    Compare with previous version

  • Wu Jeremy added 1 commit

    added 1 commit

    • b07e5c16 - Revert changes in strcuture.sql

    Compare with previous version

  • Wu Jeremy added 1 commit

    added 1 commit

    • ce918d5a - Revert changes in strcuture.sql

    Compare with previous version

  • Wu Jeremy added 1 commit

    added 1 commit

    • 06a5cd77 - Move FF stub to the start of the before action

    Compare with previous version

  • Wu Jeremy added 1 commit

    added 1 commit

    • 544e6219 - Feat: add an empty Vue component for mounting

    Compare with previous version

  • Peter Hegman removed review request for @peterhegman

    removed review request for @peterhegman

  • Peter Hegman
  • Peter Hegman
  • Hi @peterhegman :wave:

    We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.

    @JeremyWuuuuu you may also request a review by commenting @gitlab-bot ready. You can also assign reviewers directly using @gitlab-bot ready @user1 @user2 if you know the relevant reviewer(s), such as those who were involved in a related issue.

    This message was generated automatically. You're welcome to improve it.

  • requested review from @peterhegman

  • @peterhegman, this Community contribution is ready for review.

    • Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
    • Add the workflowin dev label if the merge request needs action from the author.

    This message was generated automatically. You're welcome to improve it.

  • Wu Jeremy added 1 commit

    added 1 commit

    • 2a797efc - Rename feature flag and address MR comments

    Compare with previous version

  • Wu Jeremy added 664 commits

    added 664 commits

    • 2a797efc...2ee3031d - 658 commits from branch gitlab-org:master
    • 298e1fac - Refactor: user profile page to Vue
    • 8e8fb4a6 - Test: stub the newly added FF for testing
    • c65f6b17 - Revert changes in strcuture.sql
    • e5c865fc - Move FF stub to the start of the before action
    • f0469647 - Feat: add an empty Vue component for mounting
    • b08ba785 - Rename feature flag and address MR comments

    Compare with previous version

  • Note to future reviewers: There are a lot of whitespace changes in this MR because we added a feature flag and had to indent a large block of code. If you turn off the Show whitespace changes setting in the upper right corner of the diff view it is much easier to review.

    Screenshot_2023-06-08_at_1.20.33_PM

  • Peter Hegman
  • Peter Hegman approved this merge request

    approved this merge request

  • Peter Hegman requested review from @jivanvl and @alexbuijs and removed review request for @peterhegman

    requested review from @jivanvl and @alexbuijs and removed review request for @peterhegman

  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 50a976bc and fe36c432

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.11 MB 4.11 MB - 0.0 %
    mainChunk 2.99 MB 2.99 MB - 0.0 %

    Note: We do not have exact data for 50a976bc. So we have used data from: 830415ff.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Greg Alfaro
  • Alex Buijs approved this merge request

    approved this merge request

  • Alex Buijs requested review from @dblessing and removed review request for @alexbuijs

    requested review from @dblessing and removed review request for @alexbuijs

  • Wu Jeremy added 385 commits

    added 385 commits

    • b08ba785...002b472d - 378 commits from branch gitlab-org:master
    • c5389a77 - Refactor: user profile page to Vue
    • 22c215c0 - Test: stub the newly added FF for testing
    • 247970a3 - Revert changes in strcuture.sql
    • e7f4ef95 - Move FF stub to the start of the before action
    • dd0bfacc - Feat: add an empty Vue component for mounting
    • 56076e86 - Rename feature flag and address MR comments
    • fe36c432 - Chore: use safe_format instead of html_safe

    Compare with previous version

  • Greg Alfaro approved this merge request

    approved this merge request

  • Greg Myers approved this merge request

    approved this merge request

  • Drew Blessing resolved all threads

    resolved all threads

  • Drew Blessing marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Drew Blessing approved this merge request

    approved this merge request

  • Drew Blessing enabled an automatic merge when the pipeline for acaa3ddf succeeds

    enabled an automatic merge when the pipeline for acaa3ddf succeeds

  • merged

  • @JeremyWuuuuu, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. React with a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Drew Blessing mentioned in commit 0c8898c5

    mentioned in commit 0c8898c5

  • 🤖 GitLab Bot 🤖 changed milestone to %16.1

    changed milestone to %16.1

  • Wu Jeremy mentioned in merge request !122971 (merged)

    mentioned in merge request !122971 (merged)

  • added workflowstaging label and removed workflowcanary label

  • Wu Jeremy mentioned in issue #389918

    mentioned in issue #389918

  • Please register or sign in to reply
    Loading