Skip to content

Add GraphQL version for named-list component

What does this MR do and why?

Add GraphQL version for named-list component

The named-list component is used on the new, standalone findings modal that leverages GraphQL. This commit adds the GraphQL version of the named-list component.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-06-12_at_12.37.14_pm Screenshot_2023-06-12_at_12.36.38_pm

How to set up and validate locally

Setup

  1. Have the related FF enabled: echo "Feature.enable(:standalone_finding_modal)" | rails c
  2. You'll need an EE License
  3. You'll need to have runners enabled (See $2408961 for setting up a runner)
  4. Import https://gitlab.com/gitlab-examples/security/security-reports (note: important to use the latest version, because it contains a recent fix)
  5. Run a pipeline on master

Validation

  1. Go to the pipeline's security report tab
  2. Set Filter: Tool -> DAST
  3. Click on the finding
  4. Verify that the comments section renders as in the screenshot above

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #389925 (closed)

Edited by David Pisek

Merge request reports