Skip to content
Snippets Groups Projects

Migrate terraform widget to V2

Merged Savas Vedova requested to merge 413625-migrate-terraform-widget-to-v2 into master

What does this MR do and why?

Migrates the Terraform Widget to the Widget Framework V2.

Screenshots or screen recordings

Desktop view:

terraform-widget-desktop

Mobile view:

terraform-widget-mobile

Error state:

image

How to set up and validate locally

  1. Fork https://gitlab.com/gitlab-org/frontend/playground/gitlab-mr-widgets-demo
  2. Change the README.md file to create an MR
  3. Wait for the MR to be complete
  4. Refresh the page to see the Terraform Widget

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #413625 (closed)

Edited by Savas Vedova

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Savas Vedova changed milestone to %16.1

    changed milestone to %16.1

  • assigned to @svedova

  • Author Maintainer

    This work is still incomplete. I pushed to be able to reference it.

  • mentioned in epic &10460 (closed)

  • 3 Warnings
    :warning: 824307d5: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
    :warning: 4f5a06a3: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning: This merge request has more than 20 commits which may cause issues in some of the jobs. If you see errors like missing commits, please consider squashing some commits so it is within 20 commits.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend James Rushford current availability (@jrushford) (UTC+2, same timezone as @svedova) Frédéric Caplette current availability (@f_caplette) (UTC-4, 6 hours behind @svedova)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 9c9a4757 and 062101ca

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.13 MB 4.13 MB - -0.0 %
    mainChunk 2.99 MB 2.99 MB - 0.0 %

    Note: We do not have exact data for 9c9a4757. So we have used data from: 3fb899cc.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
    • Resolved by Phil Hughes

      Allure report

      allure-report-publisher generated test report!

      e2e-test-on-gdk: :exclamation: test report for 062101ca

      expand test summary
      +-----------------------------------------------------------------------+
      |                            suites summary                             |
      +------------------+--------+--------+---------+-------+-------+--------+
      |                  | passed | failed | skipped | flaky | total | result |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
      | Create           | 8      | 0      | 1       | 6     | 9     | ❗     |
      | Monitor          | 4      | 0      | 0       | 4     | 4     | ❗     |
      | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
      | Plan             | 4      | 0      | 0       | 3     | 4     | ❗     |
      | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
      | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Total            | 21     | 0      | 2       | 14    | 23    | ❗     |
      +------------------+--------+--------+---------+-------+-------+--------+

      e2e-review-qa: :exclamation: test report for 062101ca

      expand test summary
      +-----------------------------------------------------------------------+
      |                            suites summary                             |
      +------------------+--------+--------+---------+-------+-------+--------+
      |                  | passed | failed | skipped | flaky | total | result |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
      | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
      | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
      | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
      | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
      | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
      | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Total            | 20     | 0      | 3       | 1     | 23    | ❗     |
      +------------------+--------+--------+---------+-------+-------+--------+

      e2e-package-and-test: :x: test report for 062101ca

      expand test summary
      +-----------------------------------------------------------------------+
      |                            suites summary                             |
      +------------------+--------+--------+---------+-------+-------+--------+
      |                  | passed | failed | skipped | flaky | total | result |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Plan             | 318    | 0      | 3       | 0     | 321   | ✅     |
      | Manage           | 174    | 1      | 31      | 10    | 206   | ❌     |
      | Create           | 688    | 0      | 112     | 10    | 800   | ❗     |
      | Govern           | 193    | 0      | 12      | 0     | 205   | ✅     |
      | Verify           | 196    | 0      | 20      | 4     | 216   | ❗     |
      | Package          | 233    | 0      | 46      | 24    | 279   | ❗     |
      | Data Stores      | 151    | 0      | 3       | 0     | 154   | ✅     |
      | Fulfillment      | 10     | 0      | 100     | 0     | 110   | ✅     |
      | Monitor          | 44     | 0      | 9       | 0     | 53    | ✅     |
      | Secure           | 8      | 0      | 36      | 0     | 44    | ✅     |
      | Release          | 24     | 0      | 0       | 0     | 24    | ✅     |
      | Systems          | 13     | 0      | 0       | 0     | 13    | ✅     |
      | ModelOps         | 0      | 0      | 4       | 0     | 4     | ➖     |
      | Configure        | 1      | 0      | 12      | 0     | 13    | ✅     |
      | Analytics        | 9      | 0      | 0       | 0     | 9     | ✅     |
      | GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
      | Growth           | 0      | 0      | 8       | 0     | 8     | ➖     |
      | Framework sanity | 0      | 0      | 6       | 0     | 6     | ➖     |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Total            | 2064   | 1      | 403     | 48    | 2468  | ❌     |
      +------------------+--------+--------+---------+-------+-------+--------+
      Edited by Ghost User
  • Savas Vedova added 1350 commits

    added 1350 commits

    Compare with previous version

  • Savas Vedova added 1 commit

    added 1 commit

    • 431516cf - Migrate terraform widget to V2

    Compare with previous version

  • Savas Vedova changed title from draft: first attempt to Draft: migrate terraform widget to V2

    changed title from draft: first attempt to Draft: migrate terraform widget to V2

  • Savas Vedova added 1 commit

    added 1 commit

    • dc29ae82 - Migrate terraform widget to V2

    Compare with previous version

  • Savas Vedova added 1 commit

    added 1 commit

    • 8718e9a8 - Migrate terraform widget to V2

    Compare with previous version

  • Savas Vedova added 1 commit

    added 1 commit

    • 1898ea58 - Migrate terraform widget to V2

    Compare with previous version

  • Savas Vedova
  • Savas Vedova
  • Savas Vedova
  • Savas Vedova
  • Savas Vedova
  • Savas Vedova
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading