Replace deprecated slot setters
What does this MR do and why?
This updates all remaining deprecated ViewComponent slot setter usages in our codebase.
The old way (c.SLOT_NAME
) got deprecated in the later 2.x versions of the view_component
gem and now got completely removed in the recent 3.0 release. We have to replace all deprecated calls before we can Upgrade to view_component v3.0 (#408988 - closed).
Because we had hundreds of lines in ~200 files to update, I do it in batches to get smaller, more reviewable MRs. This is one of them. The last one actually... hopefully :) See the checklist in #408988 (closed) for the already merged MRs.
Screenshots or screen recordings
No visual changes.
How to set up and validate locally
- We are currently on the latest 2.x version of the
view_component gem
. Both ways to set the slot work here, so there shouldn't be any functional changes, but feel free to browse around in the affected areas of the UI for a few samples. - Focus on the diff itself. Check that I made no search&replace mistakes there. Thanks!
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.1
added groupfoundations maintenancedependency typemaintenance labels
assigned to @thutterer
added devopsmanage sectiondev labels
1 Warning 3267f58c: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Małgorzata Ksionek (
@mksionek
) (UTC+2, same timezone as@thutterer
)Bojan Marjanović (
@bmarjanovic
) (UTC+2, same timezone as@thutterer
)frontend Payton Burdette (
@pburdette
) (UTC-4, 6 hours behind@thutterer
)Miguel Rincon (
@mrincon
) (UTC+2, same timezone as@thutterer
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Miguel Rincon
@mrincon Can you please maintainer review frontend here?
@bmarjanovic Can you please maintainerreview backend here?
Note that I skipped the first round of reviews as I did in the previous MRs in this series. See MR description for more info and links to other MRs.
Thanks!
requested review from @mrincon and @bmarjanovic
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 3267f58cexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost User@bmarjanovic
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
added pipeline:run-all-rspec label
enabled an automatic merge when the pipeline for 79a9ce89 succeeds
mentioned in commit a98391f3