Skip to content

Refactor runner list empty states

Miguel Rincon requested to merge 410602-refactor-runner-empty-states into master

What does this MR do and why?

Technical improvement before implementing #410602 (closed).

This internal change splits the implementation of the empty statue in two. The goal is to allow us to display them independently depending on the current runner state.

Screenshots or screen recordings

No changes are expected, these are the two variants we are displaying:

No runners at all No runners found
image Screenshot_2023-05-31_at_15.17.09

How to set up and validate locally

  1. You may input a filtered search in Admin -> Runners.
  2. You may visit a group that has no runners attached.

We have a comprehensive suite of tests for admin and groups, they are written like this:

it_behaves_like 'shows no runners registered'
it_behaves_like 'shows no runners found'

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #410602 (closed)

Edited by Miguel Rincon

Merge request reports