We can update the empty state when the user has no runners to create a new runner using the new method.
Proposal
Update the empty state description text to be: Runners are the agents that run your CI/CD jobs. Create a new instance runner to get started. Still using registration tokens?
Create a runner will link to the new flow.
Still using registration tokens? will link to the old modal.
If you are unsure about the correct group, please do not leave the issue without a group label, and refer to
GitLab's shared responsibility functionality guidelines
for more information on how to triage this kind of issue.
Gina Doylechanged title from Update the runner empty state create runner action to Update the runner empty state create runner action to support the new token
changed title from Update the runner empty state create runner action to Update the runner empty state create runner action to support the new token
Gina Doylechanged title from Update the runner empty state create runner action to support the new token to Update the runner empty state create runner action in groups and admin area to support the new token
changed title from Update the runner empty state create runner action to support the new token to Update the runner empty state create runner action in groups and admin area to support the new token
Gina Doylechanged the descriptionCompare with previous version
This issue's description does not seem to have a section for "Implementation Guide".
Please consider adding one, because it makes a big difference for contributors.
This section can be brief but must have clear technical guidance, like:
Hints on lines of code which may need changing
Hints on similar code/patterns that can be leveraged
Suggestions for test coverage
Ideas for breaking up the merge requests into iterative chunks
@gdoyle I finally took a deeper look at this one. We should still support users that prefer to use the registration token and I see no space for this here. Should we include something in the design to include the registration token?
@mrincon Great reminder! I can add it as a secondary button.
Question: When we remove the old registration token support, will we be able to easily remove the action to create a runner with the old reg token here?
Only when there are 0 runners, remove tabs, actions, and the filter bar and rely solely on the empty state.
@gdoyle group runners have "Show only inherited" enabled by default so removing the frame would also prevent users from switching to see all the runners if that toggle gets hidden
I can't think of a good way to remove the filter bar when we get no results, because the filter bar may still allow users to see more runners they haven't revealed.
@mrincon Thank you for bringing this up in our sync meeting today! I have updated the proposal to work for both admin and group pages now. I'll create another issue to discuss how we can improve the show only inherited toggle overall, and hopefully that will allow us to improve the empty state in the future.