Skip to content
Snippets Groups Projects

UI updates- summarize comments and description

Merged Annabel Dunstone Gray requested to merge experiment-badge-button into master
All threads resolved!

What does this MR do and why?

UI updates- summarize comments and description

  • Remove experiment badges on buttons
  • Add badge on autocomplete description header
  • Rewords content

What does this MR not do?

Screenshots or screen recordings

Before After
View summary Screenshot_2023-05-30_at_9.46.51_AM Screenshot_2023-05-30_at_9.46.34_AM
Autocomplete Screenshot_2023-05-30_at_10.23.26_AM Screenshot_2023-05-30_at_10.23.42_AM Screenshot_2023-05-30_at_10.25.05_AM Screenshot_2023-06-01_at_2.35.45_PM

How to set up and validate locally

  • AI set up
  • Feature flags:
    • :summarize_notes
    • :summarize_comments
    • :generate_description_ai
  • Go to issue
  • Top right of activity feed shouldn't have Experiment badge on button
  • Click edit
  • Autocomplete button shouldn't have Experiment badge
  • Click Autocomplete
  • Modal should have Experiment badge in title

#411677 (closed)

Edited by Annabel Dunstone Gray

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor
    2 Warnings
    :warning: This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.
    :warning: You've made some app changes, but didn't add any tests.
    That's OK as long as you're refactoring existing code,
    but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend André Luís current availability (@andr3) (UTC+1, 1 hour ahead of @annabeldunstone) Coung Ngo current availability (@cngo) (UTC+1, 1 hour ahead of @annabeldunstone)
    UX Dan Mizzi-Harris current availability (@danmh) (UTC+1, 1 hour ahead of @annabeldunstone) Maintainer review is optional for UX

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • requested review from @mvanremmerden

  • Annabel Dunstone Gray changed the description

    changed the description

  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits e734a12c and 252e97ae

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.12 MB 4.12 MB - 0.0 %
    mainChunk 2.97 MB 2.97 MB - 0.0 %

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

    • Contributor
      Resolved by Annabel Dunstone Gray

      Allure report

      allure-report-publisher generated test report!

      e2e-test-on-gdk: :exclamation: test report for 252e97ae

      expand test summary
      +-----------------------------------------------------------------------+
      |                            suites summary                             |
      +------------------+--------+--------+---------+-------+-------+--------+
      |                  | passed | failed | skipped | flaky | total | result |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
      | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
      | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
      | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
      | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
      | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
      | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
      +------------------+--------+--------+---------+-------+-------+--------+

      e2e-review-qa: :exclamation: test report for 252e97ae

      expand test summary
      +-----------------------------------------------------------------------+
      |                            suites summary                             |
      +------------------+--------+--------+---------+-------+-------+--------+
      |                  | passed | failed | skipped | flaky | total | result |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
      | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
      | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
      | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
      | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
      | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
      | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Total            | 20     | 0      | 3       | 1     | 23    | ❗     |
      +------------------+--------+--------+---------+-------+-------+--------+
    • Resolved by Annabel Dunstone Gray

      @annabeldunstone I can't yet get the actual feature to work correctly (due to me not having done the necessary AI set up), but as all changes in this MR can be reviewed without generating the description or summary, I can luckily already approve :slight_smile:

      Generate description Summarize notes
      image.png image.png

      One follow up question: The "Autocomplete" button in the modal is disabled by default. I don't think that's aligned with our guidelines. Is that something you already thought about?

  • Marcel van Remmerden approved this merge request

    approved this merge request

  • :wave: @mvanremmerden, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Marcel van Remmerden removed review request for @mvanremmerden

    removed review request for @mvanremmerden

  • requested review from @sselhorn

  • added 491 commits

    Compare with previous version

  • Annabel Dunstone Gray changed the description

    changed the description

  • Annabel Dunstone Gray resolved all threads

    resolved all threads

  • mentioned in merge request !122361 (merged)

  • Annabel Dunstone Gray changed the description

    changed the description

  • Suzanne Selhorn approved this merge request

    approved this merge request

  • Suzanne Selhorn removed review request for @sselhorn

    removed review request for @sselhorn

  • @psimyn Can you please review frontend :smile:

  • requested review from @psimyn

  • Annabel Dunstone Gray changed the description

    changed the description

  • added 1 commit

    • 252e97ae - UI updates on summarize comments and description

    Compare with previous version

  • Simon Knox approved this merge request

    approved this merge request

  • merged

  • @psimyn, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to merge when pipeline succeeds.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • Simon Knox mentioned in commit a9dd61aa

    mentioned in commit a9dd61aa

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading