UI updates- summarize comments and description
What does this MR do and why?
UI updates- summarize comments and description
- Remove experiment badges on buttons
- Add badge on autocomplete description header
- Rewords content
What does this MR not do?
- Add an alert in "populate description" modal (Add warning to issue description modal (!122361 - merged))
- Replace icon with new AI tanuki icon
Screenshots or screen recordings
Before | After | |
---|---|---|
View summary | ![]() |
![]() |
Autocomplete |
![]() ![]() |
![]() ![]() |
How to set up and validate locally
- AI set up
- Feature flags:
:summarize_notes
:summarize_comments
:generate_description_ai
- Go to issue
- Top right of activity feed shouldn't have
Experiment
badge on button - Click
edit
-
Autocomplete
button shouldn't haveExperiment
badge - Click
Autocomplete
- Modal should have
Experiment
badge in title
Merge request reports
Activity
changed milestone to %16.1
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
mentioned in merge request !121574 (merged)
- Resolved by Annabel Dunstone GrayEdited by Annabel Dunstone Gray
- Resolved by Suzanne Selhorn
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend André Luís (
@andr3
) (UTC+1, 1 hour ahead of@annabeldunstone
)Coung Ngo (
@cngo
) (UTC+1, 1 hour ahead of@annabeldunstone
)UX Dan Mizzi-Harris (
@danmh
) (UTC+1, 1 hour ahead of@annabeldunstone
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Annabel Dunstone Gray
@mvanremmerden Can you please review UX here?
requested review from @mvanremmerden
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits e734a12c and 252e97ae
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.12 MB 4.12 MB - 0.0 % mainChunk 2.97 MB 2.97 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Annabel Dunstone Gray
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 252e97aeexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 252e97aeexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
added Technical Writing UI text labels
- Resolved by Marcel van Remmerden
@annabeldunstone I think we also need the
openai_experimentation
feature flag here:
- Resolved by Annabel Dunstone Gray
@annabeldunstone I can't yet get the actual feature to work correctly (due to me not having done the necessary AI set up), but as all changes in this MR can be reviewed without generating the description or summary, I can luckily already approve
Generate description Summarize notes One follow up question: The "Autocomplete" button in the modal is disabled by default. I don't think that's aligned with our guidelines. Is that something you already thought about?
@mvanremmerden
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @mvanremmerden
requested review from @sselhorn
added 491 commits
-
6c17d0f2...2a756851 - 490 commits from branch
master
- 77dcdc65 - UI updates on summarize comments and description
-
6c17d0f2...2a756851 - 490 commits from branch
mentioned in merge request !122361 (merged)
removed review request for @sselhorn
requested review from @psimyn
added 1 commit
- 252e97ae - UI updates on summarize comments and description
@psimyn, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit a9dd61aa
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
added releasedpublished label and removed releasedcandidate label