Skip to content
Snippets Groups Projects

Exclude archived projects in search results by default

Merged Madelein van Niekerk requested to merge 18262-hide-archived-projects-by-default into master
All threads resolved!

What does this MR do and why?

Users have been requesting to exclude archived projects from the search results for the project scope.

How

  • Add a filter include_archived - added to CE since both basic and advanced search will use it
  • Exclude archived projects if the filter is not added as a parameter
  • Include archived projects if the filter is added as a parameter
  • Basic search uses the archived field on projects
  • Advanced search searches use the archived field already present in Elasticsearch

Next steps

Screenshots or screen recordings

Type Level Before After include_archived=true
Basic Global Screenshot_2023-05-29_at_13.51.59 Screenshot_2023-05-29_at_13.59.01 Screenshot_2023-05-29_at_13.59.18
Basic Group Screenshot_2023-05-29_at_13.52.40 Screenshot_2023-05-29_at_14.00.39 Screenshot_2023-05-29_at_14.01.02
Advanced Global Screenshot_2023-05-29_at_13.53.12 Screenshot_2023-05-29_at_14.02.16 Screenshot_2023-05-29_at_14.02.42
Advanced Group Screenshot_2023-05-29_at_13.53.46 Screenshot_2023-05-29_at_14.03.58 Screenshot_2023-05-29_at_14.03.37

How to set up and validate locally

  1. Do a basic search (add &basic_search=true to the url) for an existing project and verify that the project is returned in search results
    1. Without selecting a group/project
    2. With a group selected
  2. Archive the project
  3. Do the same basic searches and verify that the project is not returned
  4. Unarchive the project
  5. Do an advanced search (make sure Elasticsearch is setup) for the project and verify that the project is returned
    1. Without selecting a group/project
    2. With a group selected
  6. Archive the project
  7. Do the same advanced searches and verify that the project is not returned

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #18262 (closed)

Edited by Madelein van Niekerk

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Ghost User
  • Ghost User
  • Contributor
    4 Warnings
    :warning: This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.
    :warning: 8c0ef053: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
    :warning: c64de404: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
    :warning: Please add a merge request subtype to this merge request.
    1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Mohamed Hamda current availability (@mhamda) (UTC+2, same timezone as @maddievn) Mark Chao current availability (@lulalala) (UTC+8, 6 hours ahead of @maddievn)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • added 1 commit

    Compare with previous version

  • mentioned in issue #413237 (closed)

  • mentioned in issue #413239

  • Madelein van Niekerk marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for 92d2df4b

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Madelein van Niekerk resolved all threads

    resolved all threads

  • requested review from @sdungarwal

  • Hi @ashrafkhamis, I want to indicate that archived projects are no longer being included by default for project searches but that there is a way to have them included if a parameter is passed. Do you have an idea of where the best would be to put this in documentation?

  • Ashraf Khamis added 2 commits

    added 2 commits

    • 53ca6a90 - Update documentation for archived projects
    • aba489b8 - Merge branch '18262-update-documentation' into '18262-hide-archived-projects-by-default'

    Compare with previous version

  • A deleted user added documentation label

    added documentation label

  • Siddharth Dungarwal approved this merge request

    approved this merge request

  • :wave: @sdungarwal, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Siddharth Dungarwal requested review from @dgruzd

    requested review from @dgruzd

  • Siddharth Dungarwal removed review request for @dgruzd

    removed review request for @dgruzd

  • Dmitry Gruzd requested review from @dgruzd

    requested review from @dgruzd

  • Siddharth Dungarwal removed review request for @sdungarwal

    removed review request for @sdungarwal

  • added 1 commit

    • 92d2df4b - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Dmitry Gruzd approved this merge request

    approved this merge request

  • Dmitry Gruzd resolved all threads

    resolved all threads

  • Dmitry Gruzd enabled an automatic merge when the pipeline for aaa736e6 succeeds

    enabled an automatic merge when the pipeline for aaa736e6 succeeds

  • merged

  • Dmitry Gruzd mentioned in commit 875edd03

    mentioned in commit 875edd03

  • added workflowstaging label and removed workflowcanary label

  • mentioned in merge request !122332 (merged)

  • mentioned in issue #414900 (closed)

  • Dmitry Gruzd mentioned in work item #414903 (closed)

    mentioned in work item #414903 (closed)

  • mentioned in issue #416998 (closed)

  • mentioned in issue #421464 (closed)

  • Please register or sign in to reply
    Loading