Skip to content

Dequarantine discussion spec by sleeping after scroll

Jay McCure requested to merge jmc-deq-discussion-spec into master

What does this MR do and why?

Resolves

user_sees_discussions_navigation_spec.rb has been failing intermittently due to the scroll not being completed before the assertion occurs. This MR introduces an explicit wait after clicking prev/next thread to ensure the scroll is completed before performing the assertion.

Results

Before After - with the 1s wait
10+ errors in 20 attempts (canceled job before finishing) 0 failures in 20 attempts
https://gitlab.com/gitlab-org/gitlab/-/jobs/4365346941 https://gitlab.com/gitlab-org/gitlab/-/jobs/4365494062

How to set up and validate locally

rspec spec/features/merge_request/user_sees_discussions_navigation_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jay McCure

Merge request reports