Flaky test: spec/features/merge_request/user_sees_discussions_navigation_spec.rb
Summary
Job #4264930952 failed for 31a8e643:
1) Merge request > User sees discussions navigation Code discussions Changes page discussions navigation behaves like a page with a thread navigation with active threads cycles back to the last thread
Failure/Error: expect(page).to have_selector(second_discussion_selector, obscured: false)
expected to find visible css ".discussion[data-discussion-id='311df683cae17b597a85f4f2c8fc7748353ac56a']" but there were no matches. Also found "Sidney Jones1\n@namespace1\n· just now\nAuthor\nOwner\nMy title 5\nResolve thread", which matched the selector but not all filters.
Timeout (45s) reached while running a waiting Capybara finder.
Consider using a non-waiting finder.
See https://www.cloudbees.com/blog/faster-rails-tests
Shared Example Group: "a page with a thread navigation" called from ./spec/features/merge_request/user_sees_discussions_navigation_spec.rb:131
# ./spec/features/merge_request/user_sees_discussions_navigation_spec.rb:72:in `block (5 levels) in <main>'
# ./spec/spec_helper.rb:423:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:18:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:415:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:411:in `block (3 levels) in <top (required)>'
# ./lib/gitlab/application_context.rb:61:in `with_raw_context'
# ./spec/spec_helper.rb:411:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:242:in `block (2 levels) in <top (required)>'
# ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <main>'
# ./spec/support/fast_quarantine.rb:39:in `block (2 levels) in <main>'
# ./spec/support/database/prevent_cross_joins.rb:108:in `block (3 levels) in <main>'
# ./spec/support/database/prevent_cross_joins.rb:62:in `with_cross_joins_prevented'
# ./spec/support/database/prevent_cross_joins.rb:108:in `block (2 levels) in <main>'
Finished in 2 minutes 4.8 seconds (files took 1 minute 6.82 seconds to load)
2 examples, 1 failure
Failed examples:
rspec './spec/features/merge_request/user_sees_discussions_navigation_spec.rb[1:1:2:1:1:5]' # Merge request > User sees discussions navigation Code discussions Changes page discussions navigation behaves like a page with a thread navigation with active threads cycles back to the last thread
Randomized with seed 28869
We have 3 flaky test issues for this file that are already open:
All of them complain that the user should be SidneyX
, but it's owner
. Something is wrong in that file.
Proposed Resolution
Quarantine the entire file.
Edited by David Dieulivol