Cleanup packages_delete_orphaned_dependencies_worker FF
What does this MR do and why?
MR !20549 (merged) added two tables: packages_dependencies
and packages_dependency_links
. When a package is deleted, packages_dependency_links
rows are properly deleted but rows in packages_dependencies
are kept and they can become orphans.
MR !113076 (merged) introduced a cron worker to iterate on the packages_dependencies
table and delete those orphaned records.
We put the changes behind a feature flag and now it's globally enabled and deemed stable. This MR is to remove the feature flag.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #38266 (closed)
Merge request reports
Activity
changed milestone to %Backlog
assigned to @mkhalifa3
removed [deprecated] Accepting merge requests label
2 Warnings 67f3bdf0: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. Please add a merge request subtype to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Serhii Yarynovskyi ( @syarynovskyi
) (UTC+3)Heinrich Lee Yu ( @engwan
) (UTC+8)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c7e7b15f
removed workflowverification label
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 67f3bdf0 expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 67f3bdf0 expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Package | 150 | 0 | 18 | 141 | 168 | ❗ | | Create | 16 | 0 | 2 | 0 | 18 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 192 | 0 | 22 | 141 | 214 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
requested review from @sdungarwal
- Resolved by Kerri Miller
Hi @sdungarwal
Would you have the capacity to do the backend review for this MR? Thanks in advance
@sdungarwal
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @kerrizor
removed review request for @sdungarwal
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@fc022bea