Update Epics API for Grape 1.7 compatibility
What does this MR do and why?
Contributes to #395809 (closed)
Problem
There is a change to parameter renaming functionality in Grape >= 1.6.0. https://github.com/ruby-grape/grape/blob/master/UPGRADING.md#upgrading-to--160
We need to update parameters for compatibility reasons.
When we send start_date
(deprecated params) to Epics API, Grape converts it to start_date_fixed
and applies necessary validations. Both Grape versions 1.5.2 and 1.7.0 treat it equally.
However, when we send start_date_fixed
(an expected param). Grape 1.7.0 removes it from the declared_params
list, because it expects to receive start_date
. But current version 1.5.2 allows that.
Solution
Don't use as
for parameters renaming. Instead define two separate
params and redefine them.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.1
added backend groupproduct planning maintenancerefactor labels
assigned to @vyaklushin
added typemaintenance label
added devopsplan sectiondev labels
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Eduardo Bonet (
@eduardobonet
) (UTC+2, same timezone as@vyaklushin
)John Mason (
@john-mason
) (UTC-4, 6 hours behind@vyaklushin
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for cb66be7aexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- cb66be7a - Update Epics API for Grape 1.7 compatibility
- Resolved by James Fargher
Hi @nicolasdular!
Can you please review this refactoring as a domain expert of groupproduct planning area?
requested review from @nicolasdular
- Resolved by James Fargher
- Resolved by James Fargher
requested review from @proglottis and removed review request for @nicolasdular
@nicolasdular
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
enabled an automatic merge when the pipeline for 61f992ec succeeds
mentioned in commit c2148630
mentioned in issue #413419 (closed)
mentioned in commit 21a5b872
added workflowstaging-canary label
mentioned in merge request !122042 (merged)
mentioned in commit c1548bb2
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
mentioned in issue gitlab-org/quality/pipeline-triage#200 (closed)
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request gitlab-com/www-gitlab-com!125300 (merged)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)