Delete UI for Metrics embeds
What does this MR do and why?
Describe in detail what your merge request does and why.
Removing code for metrics rendered in GitLab flavoured markdown. Deprecated code was hidden behind the feature flag for now.
Side effect: improve setup for Vuex in unrelated unit test (more here)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
No visible changes.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
If you already had Metrics setup locally you can do these steps to include the embedded metric in an issue:
- Disable the flag that hides the Metrics:
rails c
Feature.disable(:remove_monitor_metrics)
- Navigate to the metrics dashboard: Monitor -> Metrics.
- Scroll down to the active Metrics.
- Open the top-right menu of a chart and choose 'Copy link to Chart'
- Create a new issue and paste the copied embed link in the description. Save the issue.
You shouldn't be able to see the chart after saving, no matter if the flag is disabled or enabled.
If you do not have Metrics set up locally, you can open any issue in edit mode and observe if no errors show up in the console.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #397137 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @psjakubowska
- Resolved by Jose Ivan Vargas
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Ankit Panchal (
@ankit.panchal
) (UTC+5.5, 3.5 hours ahead of@psjakubowska
)Jose Ivan Vargas (
@jivanvl
) (UTC-6, 8 hours behind@psjakubowska
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Danger
mentioned in issue #397137 (closed)
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 3f2f0e29 and 50cf56fc
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.14 MB 4.14 MB -3.13 KB -0.1 % mainChunk 3 MB 3 MB -3.13 KB -0.1 %
Note: We do not have exact data for 3f2f0e29. So we have used data from: 9a4e9c3c.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
❌ test report for 50cf56fcexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 0 | 4 | 0 | 4 | 4 | ❌ | | Create | 8 | 0 | 1 | 6 | 9 | ❗ | | Monitor | 4 | 0 | 0 | 4 | 4 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 17 | 4 | 2 | 14 | 23 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
❗ test report for 50cf56fcexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 1 | 9 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
❌ test report for 50cf56fcexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 559 | 0 | 85 | 8 | 644 | ❗ | | Package | 232 | 0 | 9 | 24 | 241 | ❗ | | Plan | 243 | 0 | 1 | 0 | 244 | ✅ | | Govern | 149 | 0 | 9 | 0 | 158 | ✅ | | Fulfillment | 8 | 0 | 75 | 0 | 83 | ✅ | | Data Stores | 117 | 0 | 3 | 0 | 120 | ✅ | | Verify | 147 | 0 | 15 | 3 | 162 | ❗ | | Secure | 6 | 0 | 27 | 0 | 33 | ✅ | | Manage | 142 | 1 | 27 | 8 | 170 | ❌ | | Systems | 11 | 0 | 0 | 0 | 11 | ✅ | | Configure | 1 | 0 | 9 | 0 | 10 | ✅ | | Monitor | 36 | 0 | 7 | 0 | 43 | ✅ | | Framework sanity | 0 | 0 | 5 | 0 | 5 | ➖ | | Analytics | 7 | 0 | 0 | 0 | 7 | ✅ | | ModelOps | 0 | 0 | 3 | 0 | 3 | ➖ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Release | 18 | 0 | 0 | 0 | 18 | ✅ | | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 1678 | 1 | 282 | 43 | 1961 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in issue gitlab-org/monitor/respond#243 (closed)
added 871 commits
-
fa42c4e7...e8bae28b - 870 commits from branch
master
- feb58478 - Delete UI for metrics embeded in markdown
-
fa42c4e7...e8bae28b - 870 commits from branch
mentioned in issue #389477 (closed)
mentioned in issue gitlab-org/monitor/respond#244 (closed)
mentioned in issue gitlab-org/monitor/respond#246 (closed)
mentioned in merge request !116730 (merged)
mentioned in issue gitlab-org/monitor/respond#247 (closed)
added 3460 commits
-
feb58478...da7013ca - 3459 commits from branch
master
- c19105f6 - Delete UI for metrics embeded in markdown
-
feb58478...da7013ca - 3459 commits from branch
added sectionsec label and removed sectionops label
changed milestone to %16.2