Skip to content

Delete UI for Metrics embeds

Paulina Sedlak-Jakubowska requested to merge 393929-metrics-delete-embeds into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Removing code for metrics rendered in GitLab flavoured markdown. Deprecated code was hidden behind the feature flag for now.

Side effect: improve setup for Vuex in unrelated unit test (more here)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

No visible changes.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

If you already had Metrics setup locally you can do these steps to include the embedded metric in an issue:

  1. Disable the flag that hides the Metrics:
rails c
Feature.disable(:remove_monitor_metrics)
  1. Navigate to the metrics dashboard: Monitor -> Metrics.
  2. Scroll down to the active Metrics.
  3. Open the top-right menu of a chart and choose 'Copy link to Chart'
  4. Create a new issue and paste the copied embed link in the description. Save the issue.

You shouldn't be able to see the chart after saving, no matter if the flag is disabled or enabled.

If you do not have Metrics set up locally, you can open any issue in edit mode and observe if no errors show up in the console.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #397137 (closed)

Edited by Paulina Sedlak-Jakubowska

Merge request reports