An error occurred while fetching this tab.
Delete UI for Metrics embeds
- Jun 28, 2023
-
-
These tests turn out to depend on a call in metrics module that is now being removed. Changelog: other EE: true
-
Changelog: removed
-
Describe in detail what your merge request does and why.
Removing code for metrics rendered in GitLab flavoured markdown. Deprecated code was hidden behind the feature flag for now.
Side effect: improve setup for Vuex in unrelated unit test (more here)
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
No visible changes.
Numbered steps to set up and validate the change are strongly suggested.
If you already had Metrics setup locally you can do these steps to include the embedded metric in an issue:
rails c
Feature.disable(:remove_monitor_metrics)
You shouldn't be able to see the chart after saving, no matter if the flag is disabled or enabled.
If you do not have Metrics set up locally, you can open any issue in edit mode and observe if no errors show up in the console.
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #397137 (closed)
These tests turn out to depend on a call in metrics module that is now being removed. Changelog: other EE: true