Skip to content
Snippets Groups Projects

Update gitlab-labkit & pg_query gems

Merged Manoj M J requested to merge mmj-upgrade-labkit into master
All threads resolved!

What does this MR do and why?

Update to pg_query to version 4.2.1 from 2.1

We need to update the version of pg_query as pg_query version 4.2.1 contains a fix that we made: https://github.com/pganalyze/pg_query/pull/285, which we need to pull in to solve an issue we are facing: !120838 (comment 1391948269).

Update to gitlab-labkit to version 0.33.0 from 0.32.0

Since gitlab-labkit depends on pg_query version 2.1 currently, labkit was also updated yesterday to use pg_query 4.2.1: gitlab-org/ruby/gems/labkit-ruby!114 (merged), and we have tagged a new version 0.33.0, so we need to update gitlab-labkit too.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Manoj M J

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Manoj M J changed the description

    changed the description

  • Manoj M J marked this merge request as ready

    marked this merge request as ready

  • Manoj M J requested review from @reprazent, @mhamda, and @sabrams

    requested review from @reprazent, @mhamda, and @sabrams

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for 0aa42cdb

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :exclamation: test report for 0aa42cdb

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 678    | 0      | 112     | 12    | 790   | ❗     |
    | Plan             | 385    | 0      | 3       | 8     | 388   | ❗     |
    | Manage           | 219    | 0      | 17      | 5     | 236   | ❗     |
    | Analytics        | 11     | 0      | 0       | 0     | 11    | ✅     |
    | Verify           | 255    | 0      | 30      | 0     | 285   | ✅     |
    | Govern           | 230    | 0      | 5       | 10    | 235   | ❗     |
    | Data Stores      | 185    | 0      | 3       | 0     | 188   | ✅     |
    | Configure        | 1      | 0      | 15      | 0     | 16    | ✅     |
    | Systems          | 19     | 0      | 0       | 8     | 19    | ❗     |
    | Release          | 30     | 0      | 0       | 0     | 30    | ✅     |
    | Monitor          | 52     | 0      | 11      | 0     | 63    | ✅     |
    | Fulfillment      | 12     | 0      | 125     | 0     | 137   | ✅     |
    | Package          | 144    | 0      | 41      | 135   | 185   | ❗     |
    | GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
    | ModelOps         | 0      | 0      | 5       | 0     | 5     | ➖     |
    | Secure           | 10     | 0      | 45      | 0     | 55    | ✅     |
    | Framework sanity | 0      | 0      | 7       | 0     | 7     | ➖     |
    | Growth           | 0      | 0      | 10      | 0     | 10    | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 2233   | 0      | 430     | 178   | 2663  | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Manoj M J added 37 commits

    added 37 commits

    Compare with previous version

  • Manoj M J marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • added databaseapproved label and removed databasereview pending label

  • Steve Abrams approved this merge request

    approved this merge request

  • :wave: @sabrams, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Steve Abrams removed review request for @sabrams

    removed review request for @sabrams

  • Setting label grouptenant scale based on @manojmj's group.

  • Stan Hu mentioned in merge request !121506 (closed)

    mentioned in merge request !121506 (closed)

  • Stan Hu
  • Mohamed Hamda approved this merge request

    approved this merge request

  • Mohamed Hamda removed review request for @mhamda

    removed review request for @mhamda

  • Bob Van Landuyt removed review request for @reprazent

    removed review request for @reprazent

  • Manoj M J added 1 commit

    added 1 commit

    • 0aa42cdb - Update gitlab-labkit & pg_query

    Compare with previous version

  • Manoj M J requested review from @reprazent

    requested review from @reprazent

  • Author Maintainer

    @reprazent this is ready for a look again :ping_pong: :slight_smile:

  • Manoj M J resolved all threads

    resolved all threads

  • Bob Van Landuyt approved this merge request

    approved this merge request

  • Bob Van Landuyt enabled an automatic merge when the pipeline for c2becf15 succeeds

    enabled an automatic merge when the pipeline for c2becf15 succeeds

  • Hello @manojmj :wave:

    The database team is looking for ways to improve the database review process and we would love your help!

    If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

    @gitlab-org/database-team

    And someone will be by shortly!

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Bob Van Landuyt mentioned in commit 570fe93c

    mentioned in commit 570fe93c

  • Manoj M J mentioned in merge request !120838 (merged)

    mentioned in merge request !120838 (merged)

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading