Update gitlab-labkit & pg_query gems
What does this MR do and why?
pg_query
to version 4.2.1
from 2.1
Update to We need to update the version of pg_query
as pg_query
version 4.2.1
contains a fix that we made: https://github.com/pganalyze/pg_query/pull/285, which we need to pull in to solve an issue we are facing: !120838 (comment 1391948269).
gitlab-labkit
to version 0.33.0
from 0.32.0
Update to Since gitlab-labkit
depends on pg_query
version 2.1
currently, labkit was also updated yesterday to use pg_query
4.2.1
: gitlab-org/ruby/gems/labkit-ruby!114 (merged), and we have tagged a new version 0.33.0
, so we need to update gitlab-labkit
too.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.1
assigned to @manojmj
- Resolved by Manoj M J
@manojmj - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
added maintenancedependency label
added typemaintenance label
mentioned in merge request gitlab-org/ruby/gems/labkit-ruby!114 (merged)
- A deleted user
added backend database databasereview pending labels
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Pedro Pombeiro (
@pedropombeiro
) (UTC+2, same timezone as@manojmj
)Terri Chu (
@terrichu
) (UTC-4, 6 hours behind@manojmj
)database Vitali Tatarintev (
@ck3g
) (UTC+2, same timezone as@manojmj
)Michał Zając (
@Quintasan
) (UTC+2, same timezone as@manojmj
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Rubygems
This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Manoj M J
- Resolved by Manoj M J
@reprazent could you please review backend?
@mhamda, @sabrams I see that both of you reviewed !117477 (merged), and we have changes in one of those files here, so could you please review database, I have added some context in !121504 (comment 1401513562).
requested review from @reprazent, @mhamda, and @sabrams
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 0aa42cdbexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 0aa42cdbexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 678 | 0 | 112 | 12 | 790 | ❗ | | Plan | 385 | 0 | 3 | 8 | 388 | ❗ | | Manage | 219 | 0 | 17 | 5 | 236 | ❗ | | Analytics | 11 | 0 | 0 | 0 | 11 | ✅ | | Verify | 255 | 0 | 30 | 0 | 285 | ✅ | | Govern | 230 | 0 | 5 | 10 | 235 | ❗ | | Data Stores | 185 | 0 | 3 | 0 | 188 | ✅ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | Systems | 19 | 0 | 0 | 8 | 19 | ❗ | | Release | 30 | 0 | 0 | 0 | 30 | ✅ | | Monitor | 52 | 0 | 11 | 0 | 63 | ✅ | | Fulfillment | 12 | 0 | 125 | 0 | 137 | ✅ | | Package | 144 | 0 | 41 | 135 | 185 | ❗ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Secure | 10 | 0 | 45 | 0 | 55 | ✅ | | Framework sanity | 0 | 0 | 7 | 0 | 7 | ➖ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2233 | 0 | 430 | 178 | 2663 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
added 37 commits
-
98e56700...ef6dd2fb - 36 commits from branch
master
- 51c0c306 - Update gitlab-labkit & pg_query
-
98e56700...ef6dd2fb - 36 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added databaseapproved label and removed databasereview pending label
@sabrams
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @sabrams
Setting label grouptenant scale based on
@manojmj
's group.added grouptenant scale label
mentioned in merge request !121506 (closed)
- Resolved by Manoj M J
removed review request for @mhamda
added devopsdata stores sectioncore platform labels
removed review request for @reprazent
requested review from @reprazent
@reprazent this is ready for a look again
enabled an automatic merge when the pipeline for c2becf15 succeeds
Thank you @manojmj
Hello @manojmj
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
mentioned in commit 570fe93c
mentioned in merge request !120838 (merged)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)