GraphQL: Remove Mutation.ciCdSettingsUpdate mutation
What does this MR do and why?
Describe in detail what your merge request does and why.
After we enabled the remove_cicd_settings_update
FF on .com to make a sync release on the 22nd, this MR removed both the Mutation.ciCdSettingsUpdate
mutation and the backing remove_cicd_settings_update
FF.
Changelog: removed
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @pedropombeiro
changed milestone to %16.1
- A deleted user
added backend documentation typefeature + 1 deleted label
1 Warning There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/graphql/reference/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Serhii Yarynovskyi (
@syarynovskyi
) (UTC+3, 1 hour ahead of@pedropombeiro
)Kassio Borges (
@kassio
) (UTC+1, 1 hour behind@pedropombeiro
)~"Verify" Reviewer review is optional for ~"Verify" Kamil Trzciński (
@ayufan
) (UTC+2, same timezone as@pedropombeiro
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@5a2dba90
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for f957615eexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for f957615eexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 255 | 0 | 25 | 0 | 280 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Create | 16 | 0 | 2 | 0 | 18 | ✅ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 297 | 0 | 29 | 0 | 326 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added feature flag label
- Resolved by Vladimir Shushlin
Hey @cwiesner
, mind doing the backend initial review? If everything's OK, please pass it on to@vshushlin
for maintainer/Verify reviewThe FF has been enabled globally yesterday, and logs from the last week show that a single user is still using this now removed functionality from .com.
Edited by Pedro Pombeiro
requested review from @cwiesner
removed review request for @cwiesner
@cwiesner
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @vshushlin
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@498b07b4
- Resolved by Vladimir Shushlin
@pedropombeiro the code is LGTM
Since the FF wasn't changed to
default_enabled: true
in %16.0, we basically releasing it as a breaking change in %16.1, which isn't idealI don't see any way not to merge it unless we want to keep it until %17.0. So, I'll merge it.
But we should try to merge all
default_enabled: true
deprecation updates in the*.0
milestone next time
enabled an automatic merge when the pipeline for 498b07b4 succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@debdf014
- Resolved by Vladimir Shushlin
Tring to merge again, no idea why it wasn't successful.
enabled an automatic merge when the pipeline for 0e7704ad succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@0e7704ad
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@80404dc8
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@6057bcc9
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@484e8c0f
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@94f7298e
- Resolved by drew stachon
@drew it looks like this requires separate verify approval. Can you take a look?
Question: do you know why I'm not on the list of verify maintainers? Shall it include all the maintainers of verify::* groups, or just selected few?
Edited by Vladimir Shushlin
requested review from @drew and removed review request for @vshushlin
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@23b7ae24
I see this removal was enabled for SaaS eight days ago, is well explained in the issue #361801 (closed), and @vshushlin already approved and set MWPS so I'm comfortable sending this now
Edited by drew stachonenabled an automatic merge when the pipeline for 2b31c56b succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@2b31c56b
mentioned in commit 020a6c88
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added sectionci label and removed sectionops label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)