GitLab Chat: Improve chat message appearance
What does this MR do and why?
Improves the chat message appearance that it looks more like a conversation.
- Set max-width to 90%
- Removes bottom shadow, see https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1583/designs/Chat_bubbles_and_actions.png#note_1401928584
Related to https://gitlab.com/gitlab-org/gitlab/-/merge_requests/12119+
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Help > Ask GitLab Chat
- Ask a question
- Verify the message & reply alignment
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.1
assigned to @seggenberger
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
mentioned in issue #411677 (closed)
- Resolved by Denys Mishunov
@annabeldunstone please review UX
cc @katiemacoy
assigned to @annabeldunstone
requested review from @annabeldunstone
unassigned @annabeldunstone
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Tomas Vik (
@viktomas
) (UTC+2, same timezone as@seggenberger
)Justin Ho (
@justin_ho
) (UTC+7, 5 hours ahead of@seggenberger
)UX Sunjung Park (
@sunjungp
) (UTC+2, same timezone as@seggenberger
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b855b7c2 and 38cbcc89
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.09 MB 4.09 MB - -0.0 % mainChunk 2.95 MB 2.95 MB - -0.0 %
Note: We do not have exact data for b855b7c2. So we have used data from: 9099db14.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in merge request !121193 (merged)
removed review request for @annabeldunstone
@annabeldunstone
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @changzhengliu
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 38cbcc89expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 2 | 0 | 0 | 1 | 2 | ❗ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-gdk:
test report for 38cbcc89expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 1 | 1 | 0 | 1 | 2 | ❌ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 1 | 2 | 1 | 23 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
requested review from @dmishunov
removed review request for @changzhengliu
- Resolved by Denys Mishunov
Hey @dmishunov can you review this frontend change? TY!
mentioned in merge request !121274 (merged)
mentioned in merge request !121420 (merged)
added 478 commits
-
baf5dee6...48d9bf99 - 477 commits from branch
master
- 24a2d701 - Tanuki Bot: Improve chat message appearance
-
baf5dee6...48d9bf99 - 477 commits from branch
added 61 commits
-
24a2d701...b78849f7 - 60 commits from branch
master
- fafcce42 - Tanuki Bot: Improve chat message appearance
-
24a2d701...b78849f7 - 60 commits from branch
- Resolved by Denys Mishunov
enabled an automatic merge when the pipeline for d4ae2fa5 succeeds
mentioned in commit c50ff1d2
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)