Removes circuit_breaker feature flag
What does this MR do and why?
It removes the circuit_breaker
feature flag from the code and makes is on by default.
FF issue: #409619 (closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @bmarjanovic
added maintenanceremoval typemaintenance labels
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Gregorius Marco (
@marcogreg
) (UTC+8, 6 hours ahead of@bmarjanovic
)Kassio Borges (
@kassio
) (UTC+1, 1 hour behind@bmarjanovic
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %16.1
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@402c8005
- Resolved by George Koltsov
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 67675444expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 67675444expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 219 | 0 | 17 | 5 | 236 | ❗ | | Create | 16 | 0 | 27 | 0 | 43 | ✅ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 260 | 0 | 46 | 5 | 306 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
Setting label groupimport and integrate based on
@bmarjanovic
's group.added groupimport and integrate label
Setting label(s) devopsmanage sectiondev based on groupimport and integrate.
added devopsmanage sectiondev labels
added 934 commits
-
53d44560...cc548b76 - 933 commits from branch
master
- 67675444 - Removes circuit_breaker FF
-
53d44560...cc548b76 - 933 commits from branch
mentioned in issue #409619 (closed)
- Resolved by George Koltsov
requested review from @mksionek
added workflowin review label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
@mksionek
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @georgekoltsov and removed review request for @mksionek
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c4c55ab4
enabled an automatic merge when the pipeline for c4c55ab4 succeeds
mentioned in commit 84bf453a
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue #408216 (closed)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
mentioned in issue bmarjanovic/growth-and-development#1