Language for workspace creation should not include Premium

added Category:Remote Development UX labels

requested review from @oregand and @ericschurter

Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.

This message was generated automatically. You're welcome to improve it.

added frontend label

2 Warnings

featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

For more information, see:

The Handbook page on merge request types.
The definition of done documentation.

You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the , , , , labels.

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	André Luís (`@andr3`) (UTC+1, 1 hour behind `@dnsmichi`)	Lukas Eipert (`@leipert`) (UTC+2, same timezone as `@dnsmichi`)
UX	Ali Ndlovu (`@andlovu`) (UTC+2, same timezone as `@dnsmichi`)	Maintainer review is optional for UX

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Proper labels assigned to this merge request. Please ignore me.

@dnsmichi - please see the following guidance and update this merge request.

	1 Error
	Please add typebug typefeature, or typemaintenance label to this merge request.

Thanks for the suggestion @dnsmichi! We had intended to fix this but it looks like it didn't get merged. @ealcantara unless there's more to it, we can just use this MR and get the change pushed out in the next release.

I left one suggestion - to leave the tier out entirely.

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits d61e39d1 and 20b5f7f3

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.02 MB	4.02 MB	-	0.0 %
mainChunk	2.88 MB	2.88 MB	-	0.0 %

Note: We do not have exact data for d61e39d1. So we have used data from: d3dd947a.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

Allure report

allure-report-publisher generated test report!

e2e-review-qa: test report for 20b5f7f3

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 50     | 0      | 1       | 0     | 51    | ✅     |
| Manage           | 8      | 0      | 3       | 0     | 11    | ✅     |
| Govern           | 20     | 0      | 1       | 0     | 21    | ✅     |
| Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
| Create           | 27     | 0      | 1       | 0     | 28    | ✅     |
| Verify           | 10     | 0      | 0       | 0     | 10    | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 150    | 0      | 8       | 0     | 158   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

added 1 commit

e65fb599 - Update gitlat.pot file

Compare with previous version

added groupide typefeature + 1 deleted label

added devopscreate sectiondev labels

added featureenhancement label and removed 1 deleted label

added 1 commit

ec2f61e9 - Remove gitlab instance tier

Compare with previous version

added 61 commits

ec2f61e9...b191f0f3 - 60 commits from branch master
a3770a9a - Remove Premium/Ultimate words from devfile help text

Compare with previous version

added 1 commit

20b5f7f3 - Remove Premium/Ultimate words from help text

Compare with previous version

changed title from Language for workspace creation should include Ultimate tier next to Premium to Language for workspace creation should not include Premium

changed milestone to %16.1

resolved all threads

approved this merge request

@oregand, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

added pipeline:mr-approved label

merged

@oregand, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:

Ensure the merge request is not in Draft status.
Start a pipeline (especially important for Community contribution merge requests).
Set the merge request to merge when pipeline succeeds.

This is a guideline, not a rule. Please consider replying to this comment for transparency.

This message was generated automatically. You're welcome to improve it.