Remove namespace select after group create fails during trial creation
What does this MR do and why?
Implements #405125 (closed).
This MR hides the namespace select when the new group option is selected and an error occurs.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Setup to simulate SaaS and restart GDK
- Visit
/-/trials/new
when you have more than 1 trial eligible namespace - Fill in company information and submit, or just skip to
-/trials/new?step=trial
- Select
Create group
from the namespace selector - Fill in invalid name, like
@ _
- See namespace select is hidden and input has group name populated
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #405125 (closed)
Merge request reports
Activity
changed milestone to %Backlog
assigned to @robyrne
2 Warnings 85383c5b: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Rad Batnag (
@radbatnag
) (UTC+8, 7 hours ahead of@robyrne
)Mayra Cabrera (
@mayra-cabrera
) (UTC-6, 7 hours behind@robyrne
)frontend André Luís (
@andr3
) (UTC+1, same timezone as@robyrne
)Paul Gascou-Vaillancourt (
@pgascouvaillancourt
) (UTC-4, 5 hours behind@robyrne
)test for spec/features/*
Rad Batnag (
@radbatnag
) (UTC+8, 7 hours ahead of@robyrne
)Maintainer review is optional for test for spec/features/*
UX Dan Mizzi-Harris (
@danmh
) (UTC+1, same timezone as@robyrne
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded UX label
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
added 1 commit
- 34f3dce1 - Remove namespace select after group create fails during trial creation
- Resolved by Ross Byrne
- Resolved by Ross Byrne
- Resolved by Ross Byrne
- Resolved by Ross Byrne
Hey
@serenafang could you take the initial backend review and the test review, please?
@deepika.guliani could you take the initial frontend review, please?
@mnearents could you do a UX review of this, please?
I've added some comments to provide context!
Thanks
requested review from @serenafang, @deepika.guliani, and @mnearents
@mnearents
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @mnearents
removed review request for @deepika.guliani
added 812 commits
-
34f3dce1...2c00d961 - 811 commits from branch
master
- 542ea785 - Remove namespace select after group create fails during trial creation
-
34f3dce1...2c00d961 - 811 commits from branch
- Resolved by Doug Stull
Due to some conflicts from !120536 (merged) I had to change my solution a little.
@serenafang could you take a quick look at the backend again and pass it on to
@dstull
for the maintainer review?@deepika.guliani could you have a look at the frontend again, please?
Thank you
requested review from @deepika.guliani
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 4e0125b2 and 818f7159
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.13 MB 4.13 MB - 0.0 % mainChunk 2.97 MB 2.97 MB - 0.0 %
Note: We do not have exact data for 4e0125b2. So we have used data from: ac2486a3.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 818f7159expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 818f7159expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 3 | 0 | 1 | 2 | 4 | ❗ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 4 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Doug Stull
- Resolved by Doug Stull
removed review request for @deepika.guliani
added 276 commits
-
542ea785...cc548b76 - 275 commits from branch
master
- 1c7fc5be - Remove namespace select after group create fails during trial creation
-
542ea785...cc548b76 - 275 commits from branch
- Resolved by Doug Stull
requested review from @dstull
requested review from @dpisek and removed review request for @serenafang
- Resolved by Ross Byrne
- Resolved by Doug Stull
- Resolved by Doug Stull
removed review request for @dstull
added 394 commits
-
bf1ecc57...a8b42232 - 391 commits from branch
master
- c54d43ed - Remove namespace select after group create fails during trial creation
- c978dd1a - Review changes
- 3ce39b90 - Fixed failing test
Toggle commit list-
bf1ecc57...a8b42232 - 391 commits from branch
requested review from @dstull
- Resolved by Doug Stull
removed review request for @dstull
added 192 commits
-
3ce39b90...96b65e10 - 188 commits from branch
master
- 898ed902 - Remove namespace select after group create fails during trial creation
- 85383c5b - Review changes
- bb13f9f0 - Fixed failing test
- 818f7159 - Fixed failing test
Toggle commit list-
3ce39b90...96b65e10 - 188 commits from branch
requested review from @dstull