Skip to content
Snippets Groups Projects

Remove namespace select after group create fails during trial creation

Merged Ross Byrne requested to merge 405125-remove-namespace-selector-after-failure into master

What does this MR do and why?

Implements #405125 (closed).

This MR hides the namespace select when the new group option is selected and an error occurs.

Screenshots or screen recordings

Before After
Screenshot_2023-05-18_at_16.12.23 Screenshot_2023-05-18_at_16.14.44

How to set up and validate locally

  1. Setup to simulate SaaS and restart GDK
  2. Visit /-/trials/new when you have more than 1 trial eligible namespace
  3. Fill in company information and submit, or just skip to -/trials/new?step=trial
  4. Select Create group from the namespace selector
  5. Fill in invalid name, like @ _
  6. See namespace select is hidden and input has group name populated

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #405125 (closed)

Edited by Ross Byrne

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ross Byrne
  • Ross Byrne
  • requested review from @serenafang, @deepika.guliani, and @mnearents

  • Matthew Nearents approved this merge request

    approved this merge request

  • :wave: @mnearents, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Matthew Nearents removed review request for @mnearents

    removed review request for @mnearents

  • Deepika Guliani approved this merge request

    approved this merge request

  • Deepika Guliani removed review request for @deepika.guliani

    removed review request for @deepika.guliani

  • Serena Fang approved this merge request

    approved this merge request

  • Ross Byrne added 812 commits

    added 812 commits

    • 34f3dce1...2c00d961 - 811 commits from branch master
    • 542ea785 - Remove namespace select after group create fails during trial creation

    Compare with previous version

  • Ross Byrne changed the description

    changed the description

  • Ross Byrne requested review from @deepika.guliani

    requested review from @deepika.guliani

  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 4e0125b2 and 818f7159

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.13 MB 4.13 MB - 0.0 %
    mainChunk 2.97 MB 2.97 MB - 0.0 %

    Note: We do not have exact data for 4e0125b2. So we have used data from: ac2486a3.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for 818f7159

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-review-qa: :exclamation: test report for 818f7159

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Plan             | 3      | 0      | 1       | 2     | 4     | ❗     |
    | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Govern           | 2      | 0      | 0       | 1     | 2     | ❗     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 20     | 0      | 3       | 4     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Doug Stull
  • Doug Stull
  • Deepika Guliani removed review request for @deepika.guliani

    removed review request for @deepika.guliani

  • Ross Byrne added 276 commits

    added 276 commits

    • 542ea785...cc548b76 - 275 commits from branch master
    • 1c7fc5be - Remove namespace select after group create fails during trial creation

    Compare with previous version

  • Ross Byrne changed the description

    changed the description

  • Ross Byrne
  • Ross Byrne requested review from @dstull

    requested review from @dstull

  • Ross Byrne requested review from @dpisek and removed review request for @serenafang

    requested review from @dpisek and removed review request for @serenafang

  • Doug Stull
  • Doug Stull
  • Doug Stull
  • Doug Stull removed review request for @dstull

    removed review request for @dstull

  • Ross Byrne added 1 commit

    added 1 commit

    Compare with previous version

  • David Pisek approved this merge request

    approved this merge request

  • Ross Byrne added 394 commits

    added 394 commits

    Compare with previous version

  • Doug Stull resolved all threads

    resolved all threads

  • Doug Stull requested review from @dstull

    requested review from @dstull

  • Doug Stull
  • Doug Stull removed review request for @dstull

    removed review request for @dstull

  • Ross Byrne added 192 commits

    added 192 commits

    Compare with previous version

  • Ross Byrne requested review from @dstull

    requested review from @dstull

  • Doug Stull approved this merge request

    approved this merge request

  • Doug Stull resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading