Fix avatar lookups by commit email on network graph
What does this MR do and why?
Describe in detail what your merge request does and why.
Fix avatar lookups by commit email on network graph. This was broken by a vulnerability fix (https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/3183) which we should bypass in this instance.
Changelog: fixed
Fixes #411541 (closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.1
assigned to @robotmay_gitlab
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Joseph Joshua (
@joseph
) (UTC+0, 1 hour behind@robotmay_gitlab
)Jessie Young (
@jessieay
) (UTC+8, 7 hours ahead of@robotmay_gitlab
)frontend Nataliia Radina (
@nradina
) (UTC+2, 1 hour ahead of@robotmay_gitlab
)Vitaly Slobodin (
@vitallium
) (UTC+2, 1 hour ahead of@robotmay_gitlab
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded bugfunctional label
- Resolved by Robert May
requested review from @anna_vovchenko and removed review request for @aalakkad
@aalakkad
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @proglottis and removed review request for @jmontal
- Resolved by Anna Vovchenko
note (non-blocking): One note I forgot to mention, since this was related to a vulnerability fix in https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/3183 should we get an appsec review as well?
Setting label groupsource code based on
@robotmay_gitlab
's group.added groupsource code label
removed review request for @proglottis
added devopscreate sectiondev labels
Setting label(s) Category:Source Code Management based on groupsource code.
added Category:Source Code Management label
- Resolved by Anna Vovchenko
Hi. Any activity on this issue? Thanks
added 1 commit
- 5305fd2c - Fix avatar lookups by commit email on network graph
added 1 commit
- 1c607b38 - Fix avatar lookups by commit email on network graph
- Resolved by Anna Vovchenko
Thanks @anna_vovchenko, I think I've answered the above questions
Edited by Robert May
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1c607b38expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in merge request !122639 (merged)
mentioned in commit 6459b90a
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
mentioned in issue #416360
mentioned in issue #411541 (closed)