Remove Metrics from main navigation
What does this MR do and why?
Describe in detail what your merge request does and why.
Remove Metrics from main navigation
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
There is no visible change, these sections are already hidden behind the feature flag.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
There is no visible change, these sections are already hidden behind the feature flag.
- Make sure the pipeline passes
- Visit any project, there shouldn't be any errors in the console related to the navbar
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #393929 (closed)
Merge request reports
Activity
changed milestone to %16.0
assigned to @psjakubowska
added docs-only label
changed milestone to %16.1
- A deleted user
added backend label
- Resolved by Fabio Pitino
1 Warning This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Mohamed Hamda (
@mhamda
) (UTC+2, same timezone as@psjakubowska
)Andy Soiron (
@Andysoiron
) (UTC+2, same timezone as@psjakubowska
)test for spec/features/*
Mohamed Hamda (
@mhamda
) (UTC+2, same timezone as@psjakubowska
)Maintainer review is optional for test for spec/features/*
~"Manage::Foundations" Reviewer review is optional for ~"Manage::Foundations" Joseph Joshua (
@joseph
) (UTC+0, 2 hours behind@psjakubowska
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger
removed docs-only label
added 488 commits
-
ab897599...2dd3f09e - 487 commits from branch
master
- 8e6569aa - Delete Metrics form navigation
-
ab897599...2dd3f09e - 487 commits from branch
removed documentation label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added workflowin review label and removed workflowin dev label
requested review from @serenafang and @leipert
@leipert
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @leipert
requested review from @fabiopitino
enabled an automatic merge when the pipeline for fa5c25d0 succeeds
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 3f95bb47expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 0 | 23 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in commit 450c79fd
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue gitlab-org/monitor/respond#243 (closed)
mentioned in issue gitlab-org/monitor/respond#244 (closed)
mentioned in issue gitlab-org/monitor/respond#246 (closed)
mentioned in issue gitlab-org/monitor/respond#247 (closed)
added releasedcandidate label
added sectionsec label and removed sectionops label
mentioned in issue gitlab-org/monitor/respond#250 (closed)
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
mentioned in issue gitlab-org/monitor/respond#251 (closed)
mentioned in issue gitlab-org/monitor/respond#252 (closed)
mentioned in issue gitlab-org/monitor/respond#254 (closed)
mentioned in issue gitlab-org/monitor/respond#259 (closed)
mentioned in issue gitlab-org/monitor/respond#260 (closed)