Remove deprecated usages of redirectTo in runners
What does this MR do and why?
Removes usages in the runner area of the deprecated function
redirectTo
in favor of visitUrl
.
Screenshots or screen recordings
NA
How to set up and validate locally
Use case, deleting a runner redirects to the list:
- Visit Admin -> Runners
- Select any runner you wish to delete
- Select "Delete runner"
- Ensure the page shown is the list at "Admin -> Runners"
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @mrincon
added devopsverify sectionops labels
changed milestone to %16.1
- Resolved by Natalia Tepluhina
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Tomas Vik (
@viktomas
) (UTC+2, same timezone as@mrincon
)Tristan Read (
@tristan.read
) (UTC+12, 10 hours ahead of@mrincon
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 9d4873fd and 84c0008b
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.02 MB 4.02 MB - -0.0 % mainChunk 2.88 MB 2.88 MB - 0.0 %
Note: We do not have exact data for 9d4873fd. So we have used data from: acc31257.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded feature flagskipped label
mentioned in issue #411561
- Resolved by Natalia Tepluhina
@jrushford can you help me review this MR? Thanks!
requested review from @jrushford
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 84c0008bexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 27 | 0 | 1 | 0 | 28 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Plan | 50 | 0 | 1 | 0 | 51 | ✅ | | Govern | 20 | 0 | 1 | 0 | 21 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 150 | 0 | 8 | 0 | 158 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
requested review from @ntepluhina
@jrushford
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @jrushford
enabled an automatic merge when the pipeline for 4e5a698c succeeds
mentioned in commit 3e927cdf
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added sectionci label and removed sectionops label