Remove batched_migrations_parallel_execution flag
What does this MR do and why?
This MR batched_migrations_parallel_execution
feature flag and some code that is not used anymore.
The flag was enabled for GitLab.com on 2023-01-25, and enabled by default in 15.11 - !114666 (merged).
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #372316 (closed)
Merge request reports
Activity
changed milestone to %15.8
assigned to @krasio
- A deleted user
added database label
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/update/background_migrations.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Aman Luthra (
@aluthra2
) (UTC+5.5, 6.5 hours behind@krasio
)Etienne Baqué (
@ebaque
) (UTC-3, 15 hours behind@krasio
)database Jarka Košanová (
@jarka
) (UTC+2, 10 hours behind@krasio
)Michał Zając (
@Quintasan
) (UTC+2, 10 hours behind@krasio
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
added 280 commits
-
31128227...021ea81f - 279 commits from branch
master
- 4d9eccaf - Remove batched_migrations_parallel_execution flag
-
31128227...021ea81f - 279 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@aab76d43
Allure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for 82c9e529expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 260 | 0 | 25 | 0 | 285 | ✅ | | Plan | 385 | 0 | 3 | 8 | 388 | ❗ | | Create | 678 | 0 | 112 | 12 | 790 | ❗ | | Govern | 195 | 0 | 40 | 0 | 235 | ✅ | | Fulfillment | 12 | 0 | 125 | 0 | 137 | ✅ | | Manage | 219 | 0 | 17 | 11 | 236 | ❗ | | Monitor | 52 | 0 | 11 | 0 | 63 | ✅ | | Data Stores | 185 | 0 | 3 | 0 | 188 | ✅ | | Secure | 10 | 0 | 45 | 0 | 55 | ✅ | | Release | 30 | 0 | 0 | 0 | 30 | ✅ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | Package | 144 | 0 | 41 | 19 | 185 | ❗ | | Analytics | 11 | 0 | 0 | 0 | 11 | ✅ | | Framework sanity | 0 | 0 | 7 | 0 | 7 | ➖ | | Systems | 19 | 0 | 0 | 8 | 19 | ❗ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2203 | 0 | 460 | 58 | 2663 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-gdk:
test report for 82c9e529expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 0 | 23 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- a6115604 - Remove batched_migrations_parallel_execution flag
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@02cf8719
changed milestone to %16.0
added missed:15.8 label
- Resolved by Kassio Borges
@praba.m7n Can you please do the initial backend and database review for this one?
Please let me know if I did the right thing in the context of
prefer_calling_context_feature_category
. Seems this was introduced after the parallel execution, but only for the case when the flag is disabled, so we did not have since it was enabled on GitLab.com in January 2023.
requested review from @praba.m7n
added workflowin review label and removed workflowcomplete label
added databasereviewed label and removed databaseactive label
requested review from @mbobin and removed review request for @praba.m7n
- Resolved by Krasimir Angelov
@praba.m7n
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@4f2f9def
changed milestone to %16.1
- Resolved by Marius Bobin
added databaseapproved label and removed databasereviewed label
removed review request for @mbobin
added 1 commit
- 82c9e529 - Remove batched_migrations_parallel_execution flag
requested review from @kassio
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@14b3f138
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
enabled an automatic merge when the pipeline for f882bd54 succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@f882bd54
Hello @krasio
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
mentioned in commit 08966970
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
mentioned in issue #384883 (closed)
added groupdatabase frameworks label and removed groupdatabase [DEPRECATED] label