Skip to content
Snippets Groups Projects

Fix edges in KeysetPaginationHelpers spec helper and add specs

Merged Michael Becker requested to merge task/404981 into master
All threads resolved!

What does this MR do and why?

Fix edges in KeysetPaginationHelpers spec helper and add specs

This is a followup change from a comment on MR 116344

We think it makes more sense to return an empty array from this helper method rather than a nil

resolves: #404981 (closed)

How to set up and validate locally

CI passes

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Merged results pipeline #867319067 passed

Pipeline: GitLab

#867325375

    Merged results pipeline passed for a613d9c2

    Test coverage 82.59% from 2 jobs
    Approval is optional

    Merged by charlie ablettcharlie ablett 1 year ago (May 15, 2023 9:59am UTC)

    Merge details

    Pipeline #867390626 passed with warnings

    Pipeline: E2E GDK

    #867398265

      Pipeline: GitLab

      #867398929

        Pipeline: E2E Omnibus GitLab EE

        #867398934

          Pipeline passed with warnings for 79916c21 on master

          Test coverage 75.82% from 2 jobs
          10 environments impacted.

          Activity

          Filter activity
          • Approvals
          • Assignees & reviewers
          • Comments (from bots)
          • Comments (from users)
          • Commits & branches
          • Edits
          • Labels
          • Lock status
          • Mentions
          • Merge request status
          • Tracking
        • Peter Leitzen approved this merge request

          approved this merge request

        • Peter Leitzen requested review from @cablett and removed review request for @splattael

          requested review from @cablett and removed review request for @splattael

        • :wave: @splattael, thanks for approving this merge request.

          This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

          For more info, please refer to the following links:

        • charlie ablett
        • charlie ablett approved this merge request

          approved this merge request

        • Peter Leitzen
        • Michael Becker added 1 commit

          added 1 commit

          Compare with previous version

        • Michael Becker resolved all threads

          resolved all threads

        • charlie ablett
        • charlie ablett approved this merge request

          approved this merge request

        • charlie ablett resolved all threads

          resolved all threads

        • charlie ablett resolved all threads

          resolved all threads

        • Great work! New pipe started and MWPS set :thumbsup:

        • charlie ablett enabled an automatic merge when the pipeline for a613d9c2 succeeds

          enabled an automatic merge when the pipeline for a613d9c2 succeeds

        • merged

        • charlie ablett mentioned in commit 79916c21

          mentioned in commit 79916c21

        • Michael Becker changed milestone to %16.0

          changed milestone to %16.0

        • added workflowstaging label and removed workflowcanary label

        • Please register or sign in to reply
          Loading