Fix edges in KeysetPaginationHelpers spec helper and add specs
What does this MR do and why?
Fix edges in KeysetPaginationHelpers spec helper and add specs
This is a followup change from a comment on MR 116344
We think it makes more sense to return an empty array from this helper
method rather than a nil
resolves: #404981 (closed)
How to set up and validate locally
CI passes
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.1
added backend devopsgovern groupcompliance maintenancetest-gap sectionsec labels
assigned to @wandering_person
added typemaintenance label
- Resolved by Michael Becker
Hello again, @splattael! Would you be able to do the initial test and backend review on this?
requested review from @splattael
1 Warning e78061ae: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Kasia Misirli (
@Kasia_Misirli
) (UTC+2, 5 hours behind@wandering_person
)Mehmet Emin Inac (
@minac
) (UTC+3, 4 hours behind@wandering_person
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by Peter Leitzen
requested review from @cablett and removed review request for @splattael
@splattael
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Michael Becker
- Resolved by charlie ablett
Cheers @wandering_person I've left two nonblocking comments. This is a great change. Thank you for working on it!
- Resolved by charlie ablett
- Resolved by charlie ablett
enabled an automatic merge when the pipeline for a613d9c2 succeeds
mentioned in commit 79916c21
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
changed milestone to %16.0
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added workflowpost-deploy-db-staging label and removed workflowproduction label